This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Steps: 1) create Web project with VWp JSF framework ERROR: pages laik index.jsp and welcomeJSF.jsp pages are created. Why? These pages should be created only in NetBeans JSF framework was selected.
I don't see welcomeJSF.jsp. index.jsp is expected by web project.
OK, maybe these pages are expected but for these pages JSF visual editor doesn't work. For me it seems that users would be confused why visual editor works for some pages and for doesn't. Therefore, we should remove these pages for visual JSF web project development.
> but for these pages JSF visual editor doesn't work. What do you mean "doesn't work"? VWP is not just VWP, it's a plugin of NetBeans Web Project. VWP is extending the web project functionality. These pages are still normal NetBeans Web project stuffs that can use non-visual JSP editor to edit. Remember that all plugin 'should not' remove the or disable the parent platform, only extending it.
There are two different behavior for JSP pages: visual editor is opened for one and for other text JSP editor is opened. I think that users will be confused from this.
Since NetBeans 5.5 + Visual Web Pack, VWP can add any non-visual JSP pages. And these pages can ONLY be opened by non-visual JSP editor. JSF is not equal to Visual. VWP is helping to add Visual page, but not remove or even make all non-visual stuffs become visual. Please remember that Visual Web framework is an extra, not a replacement of NetBeans web project. This concept was starting from NetBeans 5.5. (This concept was only for Creator) You can see how non-visual and visual stuffs work together by looking into how 'index.jsp' has a link to the visual page 'Page1.jsp'. Not all pages in users' web application must be JSF, and not all JSF page should be only edited by Visual editor.
Petre, can you comment this? Thanks P
Petr Blaha wrote: > Current situation is very strange for me. When user installs Visual JSF > support he expects that IDE will provide capability for visual editing of JSP > pages, config files, .... > > Now, we have some visual editing feature for some pages but not for all. > Maybe, it's better to ask somebody from HIE or architects. > > What's about to enable Visual JSF editing for all JSP pages when the VWP JSF > framework is selected and user can switch to text mode via JSP button in > multiview editor. This is not the intended feature for Visual Web. This is too much for at least NetBeans 6 integration. Pavel may have something to say too.
Visual editing of plain JSP pages is not planned to be supported in 6.0. When you create a page using the visual page template you can edit it visually, if you use the JSP page template you will only be able to use JPS code editor. This is similar to Mattise which can only edit classes with form files, not any .java file. I agree that when you create web project with visual JSF framework the index.jsp should NOT be created. I just wanted to file the bug for that myself :) IMO creation of these initial pages should be delegate to frameworks. I can see 2 options, but Petr Pisl owns the decision on this. My choices: 1. If no framework gets selected we should populate the project with default content (i.e. index.jsp). If the user selects a framework the framework is responsible for creating the initial content. 2. (possible but I do NOT like this as it is a hack, although it is a simple and quick fix) framework can delete the default content (index.jsp) and create its own (Page1.jsp)
I think the first solution, which is suggested by Pavel, can be taken as a hotfix. I was thinking about this more complex. The index.jsp is set up as a welcome file for the application. I think the right solution should contain appropriate api for changing the setting of welcome files as well. The question still is here, what happen, when more frameworks is selected? Which file will be the welcome file for the application? Will be the last framework, which was added. Now it can be solved as Pavel suggest and the welcome file can be changed through the deployment descriptor API. If there will be time it can be solved through spacial api in web project.
Enhancement? You are kidding? The project framework is only partly finished and IMO should not have been integrated in this state. Now it should definitely be fixed for M9!
This bug is now becoming confused because another features have been added and discussed. I changed it to 'Enhancement' because of the last request 'All JSP editors should be Visual after adding Visual Web framework!'. Now back to the 'Obsolete Pages', since it's a general web project scheme, I will reassign it to web project.
*** Issue 73352 has been marked as a duplicate of this issue. ***
Increase to P2 requested by the management. Please decrease if not possible for M9.
I have it almost done, will integrate when I get to it...
fixed: index.jsp is not registered in web.xml template, index.jsp is created and set as a welcome file in web project only if none of the frameworks set any welcome files. Struts, jsf and visual jsf fixed to register their files a welcome files (in Struts there is a small index.jsp with redirect as Struts action cannot be set as a welcome file, in jsf it is welcomeJSF.jsp, in VW it is Page1.jsp). If the framework is added into an existing web project and the project has an unmodified index.jsp then a link is added into index.jsp (same as it was). I also fixed Struts and JSF to open their welcome page after project creation (index.jsp in Struts is no open). In VW opening Page1.jsp is done differently because it requires insync to be initialized. C:\nb_all\web>cvs -q com -m "99555 create welcome pages based on the selected framework" Checking in jsf/nbproject/project.xml; /cvs/web/jsf/nbproject/project.xml,v <-- project.xml new revision: 1.18; previous revision: 1.17 done Checking in jsf/src/org/netbeans/modules/web/jsf/JSFFrameworkProvider.java; /cvs/web/jsf/src/org/netbeans/modules/web/jsf/JSFFrameworkProvider.java,v <-- JSFFrameworkProvider.java new revision: 1.16; previous revision: 1.15 done Checking in jsf/src/org/netbeans/modules/web/jsf/api/ConfigurationUtils.java; /cvs/web/jsf/src/org/netbeans/modules/web/jsf/api/ConfigurationUtils.java,v <-- ConfigurationUtils.java new revision: 1.4; previous revision: 1.3 done Checking in project/src/org/netbeans/modules/web/project/WebProject.java; /cvs/web/project/src/org/netbeans/modules/web/project/WebProject.java,v <-- WebProject.java new revision: 1.112; previous revision: 1.111 done Checking in project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java; /cvs/web/project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java,v <-- WebProjectUtilities.java new revision: 1.12; previous revision: 1.11 done Checking in project/src/org/netbeans/modules/web/project/ui/resources/web-2.3.xml; /cvs/web/project/src/org/netbeans/modules/web/project/ui/resources/web-2.3.xml,v <-- web-2.3.xml new revision: 1.3; previous revision: 1.2 done Checking in project/src/org/netbeans/modules/web/project/ui/resources/web-2.4.xml; /cvs/web/project/src/org/netbeans/modules/web/project/ui/resources/web-2.4.xml,v <-- web-2.4.xml new revision: 1.5; previous revision: 1.4 done Checking in project/src/org/netbeans/modules/web/project/ui/resources/web-2.5.xml; /cvs/web/project/src/org/netbeans/modules/web/project/ui/resources/web-2.5.xml,v <-- web-2.5.xml new revision: 1.3; previous revision: 1.2 done Checking in project/src/org/netbeans/modules/web/project/ui/wizards/NewWebProjectWizardIterator.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/wizards/NewWebProjectWizardIterator.java,v <-- NewWebProjectWizardIterator.java new revision: 1.27; previous revision: 1.26 done Checking in project/src/org/netbeans/modules/web/project/ui/wizards/PanelOptionsVisual.form; /cvs/web/project/src/org/netbeans/modules/web/project/ui/wizards/PanelOptionsVisual.form,v <-- PanelOptionsVisual.form new revision: 1.26; previous revision: 1.25 done Checking in project/src/org/netbeans/modules/web/project/ui/wizards/PanelOptionsVisual.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/wizards/PanelOptionsVisual.java,v <-- PanelOptionsVisual.java new revision: 1.35; previous revision: 1.34 done Checking in struts/src/org/netbeans/modules/web/struts/StrutsConfigUtilities.java; /cvs/web/struts/src/org/netbeans/modules/web/struts/StrutsConfigUtilities.java,v <-- StrutsConfigUtilities.java new revision: 1.16; previous revision: 1.15 done Checking in struts/src/org/netbeans/modules/web/struts/StrutsFrameworkProvider.java; /cvs/web/struts/src/org/netbeans/modules/web/struts/StrutsFrameworkProvider.java,v <-- StrutsFrameworkProvider.java new revision: 1.11; previous revision: 1.10 done Checking in struts/src/org/netbeans/modules/web/struts/resources/layer.xml; /cvs/web/struts/src/org/netbeans/modules/web/struts/resources/layer.xml,v <-- layer.xml new revision: 1.11; previous revision: 1.10 done Checking in project/jsf/nbproject/project.xml; /cvs/visualweb/project/jsf/nbproject/project.xml,v <-- project.xml new revision: 1.9; previous revision: 1.8 done Checking in project/jsf/src/org/netbeans/modules/visualweb/project/jsf/api/JsfProjectUtils.java; /cvs/visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/api/JsfProjectUtils.java,v <-- JsfProjectUtils.java new revision: 1.22; previous revision: 1.21 done Checking in project/jsf/src/org/netbeans/modules/visualweb/project/jsf/framework/JSFFrameworkProvider.java; /cvs/visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/framework/JSFFrameworkProvider.java,v <-- JSFFrameworkProvider.java new revision: 1.28; previous revision: 1.27 done Checking in golden/friend-packages.txt; /cvs/ide/golden/friend-packages.txt,v <-- friend-packages.txt new revision: 1.146; previous revision: 1.145 done Checking in golden/group-friend-packages.txt; /cvs/ide/golden/group-friend-packages.txt,v <-- group-friend-packages.txt new revision: 1.71; previous revision: 1.70 done
cvs com -m "reverting fix of 99555 because it makes internal VW build which uses old netbeans binaries fail" Checking in nbproject/project.xml; /cvs/visualweb/project/jsf/nbproject/project.xml,v <-- project.xml new revision: 1.10; previous revision: 1.9 done Checking in src/org/netbeans/modules/visualweb/project/jsf/api/JsfProjectUtils.java; /cvs/visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/api/JsfProjectUtils.java,v <-- JsfProjectUtils.java new revision: 1.23; previous revision: 1.22 done Checking in src/org/netbeans/modules/visualweb/project/jsf/framework/JSFFrameworkProvider.java; /cvs/visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/framework/JSFFrameworkProvider.java,v <-- JSFFrameworkProvider.java new revision: 1.29; previous revision: 1.28 done
the web/* part is done, apply the visualweb part when VW updates to current NetBeans build
Consider this fixed. The user visible part is done. I copied one method from visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/api/JsfProjectUtils.java into web/jsf/src/org/netbeans/modules/web/jsf/api/ConfigurationUtils.java It would be nice to remove the method from visualweb and add a project dependency on web/jsf (it is already added as a friend).
verified Product Version: NetBeans IDE 6.5 (Build 200811100001) Java: 1.6.0_10; Java HotSpot(TM) Client VM 11.0-b15 System: Linux version 2.6.27-7-generic running on i386; UTF-8; en_US (nb)