Attachment #66153 for issue #106901

View | Details | Raw Unified | Return to issue 106901
Collapse All | Expand All




    {
        mbNeedSpecialKeyHandle = true;
    }

    // FIXME:
    // #i106901#
    // if we come here outside of mbInKeyInput, this is likely to be because
    // of the keyboard viewer. For unknown reasons having no marked range
    // in this case causes a crash. So we say we have a marked range anyway
    // This is a hack, since it is not understood what a) causes that crash
    // and b) why we should have a marked range at this point.
    if( ! mbInKeyInput )
        bHasMarkedText = YES;

    return bHasMarkedText;
}

- (NSRange)markedRange
{
    // FIXME:
    // #i106901#
    // if we come here outside of mbInKeyInput, this is likely to be because
    // of the keyboard viewer. For unknown reasons having no marked range
    // in this case causes a crash. So we say we have a marked range anyway
    // This is a hack, since it is not understood what a) causes that crash
    // and b) why we should have a marked range at this point.
    if( ! mbInKeyInput )
        return NSMakeRange( 0, 0 );
    
    return [self hasMarkedText] ? mMarkedRange : NSMakeRange( NSNotFound, 0 );
}

Return to issue 106901

Lines 1328-1338 Link Here

(-)source/window/salframeview.mm (+21 lines)
1328	{	1328	{
1329	mbNeedSpecialKeyHandle = true;	1329	mbNeedSpecialKeyHandle = true;
1330	}	1330	}
		1331
		1332	// FIXME:
		1333	// #i106901#
		1334	// if we come here outside of mbInKeyInput, this is likely to be because
		1335	// of the keyboard viewer. For unknown reasons having no marked range
		1336	// in this case causes a crash. So we say we have a marked range anyway
		1337	// This is a hack, since it is not understood what a) causes that crash
		1338	// and b) why we should have a marked range at this point.
		1339	if( ! mbInKeyInput )
		1340	bHasMarkedText = YES;
		1341
1331	return bHasMarkedText;	1342	return bHasMarkedText;
1332	}	1343	}
1333		1344
1334	- (NSRange)markedRange	1345	- (NSRange)markedRange
1335	{	1346	{
		1347	// FIXME:
		1348	// #i106901#
		1349	// if we come here outside of mbInKeyInput, this is likely to be because
		1350	// of the keyboard viewer. For unknown reasons having no marked range
		1351	// in this case causes a crash. So we say we have a marked range anyway
		1352	// This is a hack, since it is not understood what a) causes that crash
		1353	// and b) why we should have a marked range at this point.
		1354	if( ! mbInKeyInput )
		1355	return NSMakeRange( 0, 0 );
		1356
1336	return [self hasMarkedText] ? mMarkedRange : NSMakeRange( NSNotFound, 0 );	1357	return [self hasMarkedText] ? mMarkedRange : NSMakeRange( NSNotFound, 0 );
1337	}	1358	}