Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | ODFF: Adapt NORMDIST and LOGNORMDIST to definition in odf spec | ||
---|---|---|---|
Product: | Calc | Reporter: | Regina Henschel <rb.henschel> |
Component: | programming | Assignee: | oc |
Status: | CLOSED FIXED | QA Contact: | issues@sc <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues |
Version: | OOo 3.0 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | PATCH | Latest Confirmation in: | --- |
Developer Difficulty: | --- | ||
Issue Depends on: | |||
Issue Blocks: | 69069 | ||
Attachments: |
Description
Regina Henschel
2009-03-11 12:05:16 UTC
Yes, sure, of course, thanks :-) Created attachment 61177 [details]
The patch is for folder 'formula'. The patch is based on CWS odff06.
Created attachment 61178 [details]
The patch is for folder 'sc'. The patch is based on CWS odff06.
Created attachment 61179 [details]
Testfile for the behavior with optional parameters
Created attachment 61181 [details]
Description, how to use the test file
Hi Eike, here are the patches, now based on CWS odff06. I have attached a file for testing the optional parameters in addition. This patch includes an improvement of the accuracy and so solves the 'Normsdist'-part in issue 69069. In cws odff06: revision 271395 formula/source/core/api/token.cxx sc/source/core/inc/interpre.hxx sc/source/core/tool/interpr3.cxx sc/source/filter/excel/xeformula.cxx sc/source/ui/src/scfuncs.src Nice testcase :-) It has some localization problem though, as the textual formula strings use a comma as decimal separator. If loaded in a locale with a different separator the checks don't match. Either one has to switch to a locale that uses a comma, e.g. de-DE German_Germany, before loading or after load and then change any cell so the =FORMULA(...) calls get updated; or the other possibility is to use the file I'll attach where I replaced the separators in content.xml. In any case, the textual function names expect an English UI; for a different UI one might try to set the environment variable OOO_CALC_USE_ENGLISH_FORMULAS=Yes prior to running the office to force that and then load the modified testcase document. Created attachment 61901 [details]
testcase using decimal point as separator
Reassigning to QA for verification. verified in internal build cws_odff06 |