Issue 100744

Summary:	errors in description.xml kill extension manager dialog
Product:	General	Reporter:	joachim.lingner
Component:	code	Assignee:	thorsten.martens
Status:	CLOSED FIXED	QA Contact:	issues@framework <issues>
Severity:	Trivial
Priority:	P3	CC:	dirk.voelzke, hj, issues, juergen.fenn, kai.sommerfeld, mdxonefour, mux2005, nesshof, stefan.baltzer, uwe.luebbers, vitriol_vitriol
Version:	DEV300m45	Keywords:	data_loss
Target Milestone:	OOo 3.3
Hardware:	All
OS:	All
Issue Type:	DEFECT	Latest Confirmation in:	---
Developer Difficulty:	---
Issue Depends on:
Issue Blocks:	111112

Description joachim.lingner 2009-04-01 13:26:19 UTC

The update of the writer2latex extension to version 1-beta caused that the
extension manager dialog could not be started. The reason was that the
description.xml contained references to description files, which where wrong.
The relative paths where "description/description_lang.xml" but the description
files were in the root and not in the subdiretory "description". This caused a
DeploymentException whenever one tries to obtain the description
(desktop/source/deployment/registry/package/dp_package.cxx:BackendImpl::PackageImpl::getDescription())

The GUI part does not catch this extension. The exception is throuwn already
when the extension manager GUI is instantiated, which then fails completly.

XPackage::getDescription is currently not defined to throw a particular exception.

A similar problem can occur with all resources which are references from the
description.xml and which target files within the extension. This applies to :

-license
-icon
-extension description

license: In this case the function BackendImpl::PackageImpl::checkLicense (
desktop/source/deployment/registry/dp_package.cxx) throws a DeploymentException
which is correct (test it!).

icon: In BackendImpl::PackageImpl::getIcon a call to
XGraphicProvider::queryGraphic is done which probably throws a IOException
(http://api.openoffice.org/docs/common/ref/com/sun/star/graphic/XGraphicProvider.html#queryGraphic).
This is also not declared in XPackage.idl

extension description: see above

Comment 1 joachim.lingner 2009-04-01 13:39:57 UTC

Comment 2 stefan.baltzer 2009-04-03 13:14:05 UTC

Current situation: 
In OOo 3.1 (currently build OOO310_m9 is announced as RC1) the Writer2LateX
extension 0.5 is pre-bundled. Thus clicking "Check for updates" in the Extension
manager wil lead by default to an installation of the Writer2LateX extension v
1.0 Beta. There will be no warning, no "are you sure".
The W2L page of the Extension Repository will not be shown, so the little
warning there "The extension cannot be installed in OOo 3.1 – the Extension
Manager crashes permanently" can not be read.
After the extension update, the office will crash on EVERY start. And restart
automatically into the next crash. This makes this issue Prio P2.

I see three solutions so far:
(1) Remove pre-bundled W2L extension from Office. This will save "Check for
update" users their office.
(2) Remove the 1.0 Beta Version from the Ext. Repository until it is replaced
with a "3.1 compatible one"
(3) Fix this issue before 3.1 Release.

Given the state of the release (RC is out), I regard (1) and (2) as feasible.
Solution (3) looks risky to me.

Comment 3 Martin Hollmichel 2009-04-03 14:26:34 UTC

the writer2latex extension source code is now hosted on source forge and by a
look in the source header these are exclusive copyright by Henrik Just.
According to our guidelines for bundling extensions we cannot bundle extensions
which are not covered by the guidelines to contribute (meaning SCA). So unless
these sources will not contributed to OOo (which would be my preferred solution)
we need to unbundle this extension. As a side effect this issue will be resolved.

anyhow, the initial description was that there is a problem with the
description.xml I would be glad if we can Henrik a hint how can this be fixed as
his side and if this also is a stopper problem for 3.1 release.

Comment 4 Martin Hollmichel 2009-04-03 15:29:19 UTC

@is: please remove from install set.

Comment 5 joachim.lingner 2009-04-03 16:01:31 UTC

Please do not hijack this issue. It is intended to fix the issue in the
extension manager. Please write a new issue regarding the unbundling of the
writer2latex extension. BTW, KSO notified the publisher of the problem and he
said that he will fix it soon.

Obviously there is a difference in DEV300m45 and OOO310m10. In the first the
extension manager does not start while in the latter the office "allegedly"
crashes. I'll have a look. Until then I will set this issue back to its previous
owner (me) and target.

Comment 6 joachim.lingner 2009-04-03 16:03:25 UTC

Comment 7 stefan.baltzer 2009-04-03 16:26:58 UTC

I fully agree with JL. Set this one to target OOo 3.2 again.

Follow-up issue is 100836 "Remove writer2latex extension from ooo3.1
installation set" assigned to IS with target 3.1.

Comment 8 ingo.schmidt-rosbiegal 2009-04-03 16:29:05 UTC

I created task i100836 to remove the writer2latex extension from ooo3.1
installation sets.

Comment 9 rene 2009-04-03 16:47:05 UTC

if you unbundle it (and IMHO this also should  be the fix for Issue 100836) you
should remove it completely from the tree. It was since ever a external
"extension" (before 0.5 a .uno.pkg/.zip, since 0.5 a oxt) and people who want
it can get it from there.

Having it in OOos code only make sense if it is bundled, otherwise people can just
download it from sf itself.

Comment 10 rene 2009-04-03 16:47:52 UTC

(why is hendrik just CCed here at all?)

Comment 11 henrikjust 2009-04-04 13:08:24 UTC

I have temporarily removed Writer2LaTeX 1.0 beta from extensions.openoffice.org
to avoid problems for OOo 3.1 users. I have fixed the typo in description.xml
and will release a new beta version when I have tested it against OOo 3.1 rc.

I don't have any particular opinion about bundling Writer2LaTeX with OOo or not.

Comment 12 juergenfenn 2009-04-07 20:22:31 UTC

I am strongly in favour of bundling w2l with OOo. It has been bundled since OOo
2, and the LaTeX community as well as some publishers rely on OOo coming with
LaTeX export filter. So could you please include w2l 0.5 in OOo 3.1. Please cf.
also my comments on issue #100836.

Comment 13 joachim.lingner 2009-08-03 11:34:44 UTC

*** Issue 103541 has been marked as a duplicate of this issue. ***

Comment 14 joachim.lingner 2009-09-01 09:01:32 UTC

Target 3.3

Comment 15 joachim.lingner 2010-02-05 13:08:43 UTC

Retargeting to 3.x.

Comment 16 kai.sommerfeld 2010-06-28 08:41:25 UTC

jl: Just encpontered this very nasty problem with dev300 m83 and an extension I
just was playing around with. We really should try to fix this for 3.4.

Comment 17 dirk.voelzke 2010-08-25 13:34:37 UTC

Fixed in cws jl155

Comment 18 dirk.voelzke 2010-11-04 15:06:25 UTC

Please verify and send back to re-verify for cws jl155.

Comment 19 mdxonefour 2010-11-04 15:18:21 UTC

md: according to dv this fix has become part of CWS tl88

Comment 20 thorsten.martens 2010-11-04 15:45:21 UTC

Checked and verified in cws tl88. Problem with the extension-manager and/or
defect extensions seems to be fixed and looks good.
However, using the Linux build of this cws and trying to travel to "tausch"
within the extension-manager for adding a new extension, leads to a crash.

Comment 21 thorsten.martens 2010-11-05 10:44:23 UTC

Crash seems to be related to my testmashine only

Comment 22 thorsten.martens 2010-11-05 12:30:42 UTC

In Win OK too !

Comment 23 joachim.lingner 2011-02-16 13:06:27 UTC

fixed in tl88 which was integrated in OOo 3.3