Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Can't delete note when selecting a drawing object | ||
---|---|---|---|
Product: | Writer | Reporter: | amy2008 <amy2008> |
Component: | editing | Assignee: | max.odendahl |
Status: | CLOSED FIXED | QA Contact: | issues@sw <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues, ooo.redflag, os_ooo, peter.junge, zhuangyuelin |
Version: | DEV300m51 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- | ||
Issue Depends on: | |||
Issue Blocks: | 84405 |
Description
amy2008
2009-07-07 02:35:11 UTC
Have checked in OOo3.0 on WinXP and Fedora, can reproduce it too. Further, At step 4, Select the drawing object, then click the drop down arrow of the Notes, select "Delete note", pay attention to the selected drawing, the drawing object lost its focus (without 8 points). confirmed mod->os: I tried ResetSelect as a first call inside WrtShell::GotoField, but did not help. Any insight or help from your side into this issue? Thanks! ->mod: There is some odd behaviour when drawings are selected. The code you call can only be executed in text mode. To achieve this the drawing or frame selection must be removed and the TextShell need to be put on top of the dispatcher stack. The changes below do that (for deletion of notes from a certain author only) Jumping to a text content using double click in the Navigator also doesn't work when a drawing is selected. Index: source/ui/docvw/postit.cxx =================================================================== --- source/ui/docvw/postit.cxx (revision 273580) +++ source/ui/docvw/postit.cxx (working copy) @@ -1311,6 +1311,16 @@ case FN_DELETE_NOTE_AUTHOR: case FN_HIDE_NOTE_AUTHOR: { + SwWrtShell& rSh = mpView->GetWrtShell(); + if( rSh.IsSelFrmMode() || rSh.IsObjSelected()) + { + rSh.UnSelectFrm(); + rSh.LeaveSelFrmMode(); + rSh.EnterStdMode(); + rSh.DrawSelChanged(); + mpView->StopShellTimer(); + } + // not possible as slot as this would require that "this" is the active postit SfxStringItem aItem( nSlot, GetAuthor() ); const SfxPoolItem* aItems[2]; Index: source/ui/wrtsh/select.cxx =================================================================== --- source/ui/wrtsh/select.cxx (revision 273257) +++ source/ui/wrtsh/select.cxx (working copy) @@ -337,6 +337,7 @@ // Rahmenselektion aufheben mit garantiert ungueltiger Position Point aPt(LONG_MIN, LONG_MIN); SelectObj(aPt, 0); + GetView().LeaveDrawCreate(); SwTransferable::ClearSelection( *this ); } mod->os: great, thanks for your help, will fix this(and some other related navigator deletion issues) in notes10. When the cursor is inside a draw object in editmode instead of only being selected, I got a crash using this scenario, see issue 103645. With your changes, I now get: SwFEShell::IsFrmVertical: missing SwContact instance at marked object-> This is a serious issue, please inform OD SwFEShell::GetObjAttr: missing pContact - please inform OD and then a crash as well. As this is related to this issue, would you have a look into that as well? ->mod: I think the crash and the assertion are related to issue 102752 ->os: no, using the patch from there does not fix the crash... fixed in notes10, including navigator behaviour Verified in CWS notes10 |