Issue 104876

Summary:	Basic is treated as modified even if there are no modifications.
Product:	General	Reporter:	mikhail.voytenko
Component:	code	Assignee:	ab
Status:	CLOSED FIXED	QA Contact:	issues@framework <issues>
Severity:	Trivial
Priority:	P3	CC:	issues
Version:	DEV300m56
Target Milestone:	3.4.0
Hardware:	All
OS:	All
Issue Type:	DEFECT	Latest Confirmation in:	---
Developer Difficulty:	---

Description mikhail.voytenko 2009-09-08 07:37:35 UTC

The problem is that the BasicManager behaves as modified one every time a
document containing scripts is stored(
SfxBasicManagerHolder::isAnyContainerModified() returns true ).

As we have discussed there was already a bug that this method returned true,
because a document without dialog libraries had always got ¨Standard¨ library,
and the DialogContainer was modified then. But this time the BasicContainer is
modified, although I have only opened a document and saved it ( Save operation
). Could you please take a look.

This fix is important to be used for optimizing transfer of scripting signature
on document storing.

Comment 1 mikhail.voytenko 2009-09-08 13:29:51 UTC

There are two scenarios that look to be a little bit different:
- a document with basic script is used
- a document with another type of script is used ( without basic )

In both cases "SfxBasicManagerHolder::isAnyContainerModified()" returns true if
just loaded document is stored. There seems to be no scenario to test it in
office, it is just an API issue.

Comment 2 ab 2009-09-08 13:54:55 UTC

ab->mav: But shouldn't this be reproducible by using documents
with signed macros as described in #i85306, at least as long
as encsig09 is not integrated?

STARTED

Comment 3 mikhail.voytenko 2009-09-08 14:53:21 UTC

mav->ab: Yes, you are right, current builds of office still use the function.

Comment 4 ab 2010-06-04 11:43:53 UTC

Not enough time left for 3.3 -> 3.4

Comment 5 ab 2011-01-06 14:19:43 UTC

FIXED

Comment 6 mikhail.voytenko 2011-01-07 10:30:50 UTC

Verified by code review.