Issue 105391

Summary: databse ist not being saved when clicking on "save all"
Product: Base Reporter: drmartinus <drmartinus>
Component: codeAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Trivial    
Priority: P3 CC: drewjensen.inbox, issues, r4zoli
Version: DEV300m21Keywords: usability
Target Milestone: ---   
Hardware: PC   
OS: Linux, all   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---

Description drmartinus 2009-09-27 05:15:14 UTC
When selecting "save all" (or similiar, I translated) in the files menu, a changed database does 
not seem to be saved.
Comment 1 r4zoli 2009-09-27 18:49:10 UTC
Please give more information on your OOo version, linux distribution. From what
source you installed OOo? 
What database type this happens? Built-in or connected to external source?
What does you means under "database doesnot seem to be saved".
http://qa.openoffice.org/issue_handling/basic_rules.html#reproducibility

  
Comment 2 drmartinus 2009-09-29 17:20:37 UTC
Running under KDE 4.3, OpenSuse 11.1, OOo Build 9319, i.e. 310m21.
I installed from the OpenSuse Openoffice repository. 
It's a built in database.
What happens:
I work on a database (let's say I add a report, or a query, or change a form).
Then I work on other documents too, which remain open. Since I don't trust the
autosave (I have weird results there, too, but that's another issue), I click
from time to time on "save all" in the file menu.
All documents are being saved, the appropriate icon for saving the document is
greyed out on all documents except the database. It remains unsaved, the save
icon is still in full colour, only when I click on it, it's being saved.

Hope that clarifies it. Ask if there are further questions.
Comment 3 r4zoli 2009-09-29 17:32:35 UTC
Opensuse OOo version supported by other source, this is not a right place to
submit issues here with that version only for OOo downloaded from openoffice.org
site. Use https://bugzilla.novell.com/index.cgi. Closing.
Comment 4 drewjensen.inbox 2009-09-29 17:58:07 UTC
Checked w/ DEV300m_60 and XP 

To reproduce:

Open any ODB file.
Create a new query definition, close the query designer but DO NOT save the odb
file.
Open a new OpenDocument Text document.
Edit the file so that the menu item File>Save All is available and execute it.
The Base file does not save.

OK - first I changed the sub-component on this issue to 'none' as it is common
to Base files not just MySQL connector.

Second - there are questions, IMO, as to what is the correct way to handle open,
modified, Base component windows - but I can't see how in this use case (only a
modified Base file main windows is open when Save All is executed) the Base file
should not be saved.

Confirming, assigning to developer, setting initial target and adding keyword
usability.
Comment 5 drewjensen.inbox 2009-09-29 18:00:12 UTC
seems two of us looked at this at ~the same time.

r4zoli - please note that this is not a situation limited to a particular
distribution per my comments
Comment 6 Frank Schönheit 2009-09-30 09:08:54 UTC
congratulations, you found code piece no. 154.235 (approximately) which cares
for SFX-based documents only, and ignores Base.

fs->atjensen: when you target and assign an issue (thanks!), then please do not
forget to also confirm it. UNCONFIRMED issues have a much bigger chance to slip,
since they do not appear in usual queries and statistics.
Comment 7 Frank Schönheit 2009-09-30 10:31:01 UTC
fs->mba: /me thinks SfxApplication::MiscState_Impl/MiscExec_Impl should care for
the non-SFX documents, too. Which could turn out to be difficult, since it seems
there's no UNO API equivalent for SfxObjectShell::ExecuteSlot (each modified doc
is currently saved by executing a SID_SAVEDOC request), at least no
*synchronous* one. Which makes the proper handling for storing previously
unsaved documents, which are expected to open a "Save As" dialog, cumbersome.
Comment 8 Mathias_Bauer 2009-09-30 15:42:46 UTC
I always wanted to move the code handling dispatches on a global ("application")
level outside of sfx2, not only because of bugs like this one, also because I
don't see sfx2 as something that should be involved in such global
functionality. I will take this issue as a good reason to move that forward. :-)
Comment 9 Marcus 2017-05-20 10:47:50 UTC
Reset assigne to the default "issues@openoffice.apache.org".