Issue 109062

Summary: extensions: Extension Manager not working if extension contains wrong description.xml (here: extension-description)
Product: General Reporter: cfries <email>
Component: uiAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Major    
Priority: P2 CC: elish, email, issues, joachim.lingner, marcelly.bernard, mdxonefour
Version: OOO310m19   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: 4.1.0-dev
Developer Difficulty: ---

Description cfries 2010-02-08 23:37:55 UTC
If an extension contains a file description.xml having an extension-description element where the 
xlink:href is an URL starting with http:// then the extension manager does not show up any more.


How to reproduce this problem quickly:

1. Open the directory
~/Library/Application\ Support/OpenOffice.org/3/user/uno_packages/cache/uno_packages
This is the location where OpenOffice stores extensions.

2. Open a subdirectory and its subdirectory. You should see the description.xml of one of your OO 
extensions (I assume that you have installed at least one).

3. Add the following lines to description.xml:

	<extension-description>
		<src xlink:href="http://www.somehost.com/somedirectory/extension-description.txt" 
lang="en" />
	</extension-description>  

4. Safe this description.xml.

5. Restart OpenOffice

6. Bring up "Extension Manager..."

Result: Extension Manager will not come up. It is impossible to uninstall the extension through OO.

To Recover: Open the file again, delete the "extension-description" element.

Note: From the developer documentation it is not clear that extension-description has to point to a 
local file.
Comment 1 Olaf Felka 2010-02-09 06:47:11 UTC
@ jsk & jl: Please have a look. Sounds like something  that we should fix asap.
Comment 2 joachim.lingner 2010-02-09 08:48:01 UTC
@jsk: When you can reproduce this, then assign it to me.
As for the documentation, it says:

"One can put a couple of localized description files into the extension and
reference them in the description.xml. "

(http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Extension_Description)

This may be expressed more clearly.
Comment 3 cfries 2010-02-09 11:33:40 UTC
The problem also exists if the extension-description element of description.xml refers to a non-
existing local file.

To reproduce this problem quickly replace step 3 above by

3b. Add the following lines to description.xml:

	<extension-description>
		<src xlink:href="bla.txt" lang="en" />
	</extension-description>  


Note: The problem is that in my situation an extension with the erroneous description.xml file installs, 
but once it is installed, extension manager does not show up anymore, hence it cannot be unstalled or 
update.

@jl: Thanks for the reference. I now see that the developer documentation states "One can put a couple 
of localized description files into the extension and reference them in the description.xml. ". But when I 
read the documentation of description.xml it was not clear which element has to (!) refer to a local file 
and which element can (!) also refer to a remote file. For example release-notes can refer to a remote 
file. Nevertheless, the problem is not tied to the fact that extension-description referred to a remote 
file.
Comment 4 joachim.lingner 2010-02-09 13:43:26 UTC
As for the non-existing file, there is already issue  100744.
Comment 5 bmarcelly 2010-02-10 07:16:07 UTC
The text in the Wiki page Extension_Description is a general description. But
even here, the expression _into_ the extension clearly says that the file cannot
be anywhere in the internet.

The syntax is described in the referenced Wiki page
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fextension-description

There it says :
"xlink:href 	Required. The value is a relative URL to the description file
within the extension."

IMHO this is perfectly clear : 
- the description file is _within_ the extension
- hence an http URL cannot be a relative URL to that file.
Comment 6 cfries 2010-02-10 08:29:16 UTC
@bmarcelly: Thank you. I have overlooked this. The documentation is perfectly clear.

Regarding the issue itself, that extension manager is killed if the xlink:href points to a non existing file, it 
is part of of issue 100744

I see this issue as a bigger problem than the priority of 100744 suggest. If an extension with such a faulty 
description.xml is deployed (e.g. via update), then the average user likely needs to make a clean reinstall 
of OO to recover from this problem. It is not even possible to update the faulty extension to a fixed 
version.
Comment 7 hans_werner67 2011-03-28 11:57:10 UTC
Assign to new default-assignee
Comment 8 Edwin Sharp 2014-02-06 19:47:08 UTC
Crash at step 6
AOO410m1(Build:9750)  -  Rev. 1562493
Rev.1562493
Win 7