Issue 11004

Summary:

Meta modifier awareness for VCL and accelerators

Product:

gsl

Reporter:

Component:

code

Assignee:

fa <dan>

Status:

CLOSED DUPLICATE

QA Contact:

issues@gsl <issues>

Severity:

Trivial

Priority:

CC:

eric.bachard, issues

Version:

OOo 1.0.0

Target Milestone:

OOo PleaseHelp

Hardware:

Mac

OS:

Mac OS X, all

Issue Type:

ENHANCEMENT

Latest Confirmation in:

---

Developer Difficulty:

---

Issue Depends on:

Issue Blocks:

61866

Attachments:

Description	Flags
cd SRC_ROOT/vcl; patch -p0 < vcl.OOO_STABLE_1_PORTS.012803.patch	none
cd SRC_ROOT/sfx2; patch -p0 < sfx2.OOO_STABLE_1_PORTS.012803.patch	none

Description ed 2003-01-28 08:48:26 UTC

These patches add in awareness of the Meta keyboard modifier to the unx VCL variant.  This is important for MacOS X as it can allow for the Command key (mapped usually to Meta) to be used for keyboard accelerators, creating a more familiar environment with other standard OS X appliactions where Control is a very infrequenstly used modifier.

This enhancement is achieved through adding in a new keyboard modifier, KEY_MOD3.  To make room for this modifier, the KEY_CONTROLMOD flag was removed from the modifiers field.  CONTROLMOD appears to only be used for menu based accelerators (the Alt-letter combination), and in the Win32, Unix, and OS/2 VCLs the only way CONTROLMOD was set was when Mod2 was pressed/set and Mod1 was not.  It therefore conveyed no additional information beyond the existing Mod1 and Mod2 modifier flags.  CONTROLMOD was removed, and the KeyCode IsControlMod() replaced with a comparison yielding true when only Mod2 is depressed.

sfx2's accelerator configuration was altered.  The accelerator configuration list now lists various Meta combinations.  The acclerator XML storage was also expanded to accommodate the new meta modifier.  In the SfxAcceleratorManager, a few logic errors that used signed shorts instead of unsigned shorts had to be corrected.

Comment 1 ed 2003-01-28 08:49:29 UTC

Created attachment 4452 [details]
cd SRC_ROOT/vcl; patch -p0 < vcl.OOO_STABLE_1_PORTS.012803.patch

Comment 2 ed 2003-01-28 08:50:23 UTC

Created attachment 4453 [details]
cd SRC_ROOT/sfx2; patch -p0 < sfx2.OOO_STABLE_1_PORTS.012803.patch

Comment 3 christof.pintaske 2003-02-06 12:43:17 UTC

patch is trivial for VCL but not for SFX. So I put this on the 2.0 pile

Comment 4 ingenstans 2003-09-22 04:06:44 UTC

would this patch also make available the alt key as a modifier under 
Windows? I ask because (1) this would vbew a good thing and (2), if it 
it's true, I can close Issue #32 as a duplicate which has been fixed.

and, no, #32 is not a misprint.

Comment 5 christof.pintaske 2004-03-02 15:00:19 UTC

cp->fa: sorry, I lost track of this issue. Didn't we agree on some solution for
this ? Do we still need this ?

Comment 6 Martin Hollmichel 2005-02-07 10:45:08 UTC

set target to Please Help because of lack of resource.

Comment 7 eric.bachard 2005-08-22 15:06:30 UTC

Very interesting issue.  If we can use this, maybe we can find a workaround for 
<http://www.openoffice.org/issues/show_bug.cgi?id=49752>

Comment 8 jjmckenzie 2007-02-05 03:34:06 UTC

@ericb:

Is this issue still needed?  I think that the Meta Key now works for the 2.1
release as a substitute for the Cntrl key.

James McKenzie

Comment 9 jjmckenzie 2007-02-05 03:39:57 UTC

Confirmed that Applescript fix did include support for the Meta Key.  This issue
can be closed at this time as a fix does exist.  However, this does not allow
for two sets of modifiers (one for the Cntrl key and a second for the Meta key)
to exist.

James McKenzie

Comment 10 moxfox 2009-04-04 13:44:16 UTC

This bug has been re-invented as issue 99254.

Since issue 99254 is actually getting integrated, marking this issue as duplicate

*** This issue has been marked as a duplicate of 99254 ***

Comment 11 Mechtilde 2009-07-12 17:48:30 UTC

duplicate -> closed

Comment 12 Mechtilde 2009-07-12 17:49:00 UTC