Issue 112407

Summary:

vcl: suspicious push_back in sun-specific xinerama code

Product:

gsl

Reporter:

caolanm

Component:

code

Assignee:

caolanm

Status:

CLOSED FIXED

QA Contact:

issues@gsl <issues>

Severity:

Trivial

Priority:

CC:

issues

Version:

DEV300m81

Keywords:

regression

Target Milestone:

OOo 3.3

Hardware:

Unknown

OS:

All

Issue Type:

PATCH

Latest Confirmation in:

---

Developer Difficulty:

---

Attachments:

Description	Flags
fix it up like this I bet	none

Description caolanm 2010-06-15 10:14:21 UTC

We have a addXineramaScreenUnique method which uses push_back to append a
xinerama/xrandr framebuffer/monitor to our list and ignore duplicates. I see in
passing that the #ifdef USE_XINERAMA_XSUN stuff start off with...

m_aXineramaScreens = std::vector<Rectangle>( nFramebuffers );
...
addXineramaScreenUnique(...)

which would suggest that m_aXineramaScreens ends up typically twice as big as it
should be, with invalid default ctored Rectangles as the first half

Comment 1 caolanm 2010-06-15 10:14:45 UTC

Created attachment 70007 [details]
fix it up like this I bet

Comment 2 philipp.lohmann 2010-06-15 10:46:57 UTC

oops. yours truly messed that up, yes. thanks for finding that.

committed in CWS ooo30gsl01

Comment 3 philipp.lohmann 2010-06-16 14:39:04 UTC

changeset at http://hg.services.openoffice.org/hg/cws/ooo30gsl01/rev/579bfa7471ec

please verify in CWS ooo30gsl01

Comment 4 caolanm 2010-06-16 14:40:34 UTC

make sense now

Comment 5 caolanm 2010-08-03 12:40:22 UTC

seen in master