|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Bitmaps in the background of master page not visible in slide show | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Impress | Reporter: | wolframgarten | ||||
| Component: | ui | Assignee: | wolframgarten | ||||
| Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> | ||||
| Severity: | Trivial | ||||||
| Priority: | P2 | CC: | clippka, groucho266, issues | ||||
| Version: | DEV300m82 | Keywords: | regression | ||||
| Target Milestone: | OOo 3.3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
| Developer Difficulty: | --- | ||||||
| Attachments: |
|
||||||
|
Description
wolframgarten
2010-06-22 14:17:40 UTC
AW: Not working in DEV300m80. AW: Not working in DEV300m78. AW: Not working in DEV300m76. AW: Seems not to work for a while (which is frightening). Who is guessing i caused it, BTW...? AW: Looking for even older versions... The clue came from cl.. ;-) AW: Works in DEV300m75 unxlngi6.pro. CWS aw079 was integrated in DEV300m76, so it may have to do with #i99386#, the MPBGO removal. It will depend in which way the Slideshow retrieves the graphical data for the background. Need to ask AF... added keyword AW: Has nothing to do with bitmaps, is a general problem with page FillStyles. The UNOGraphicExporter gets the background from the given page which is not the masterpage. It creates a temporary SdrObject with it to stay compatible with the old MPBGO. The SdrPageProperties from that page get used directly which have a fillstyle of XFILL_NONE. The error is the direct usage of SdrPageProperties from that page; if it has a MasterPage and fillstyle is XFILLSTYLE_NONE, use the fill attributes from the Masterpage (also take a look that SdrPageProperties from MaterPage HAS a StyleSheet, else the pool default blue8 will be used). That error does not happen when modifying the PageStyle interactively, looks like the SdrPageProperties from the SdrPage get set directly, too. AW: Problem is indeed that the temporary shape got not the right SfxItemSet from the right page. Added getCorrectSdrPageProperties() to SdrPage and MasterPageDescriptor to not have the code double somewhere; adapted usages in GraphicExporter and ViewContactOfMasterPageDescriptor. AW: Unfortunately, this was not enough yet. When the MasterPage has the SfxItemSet, there are NO items set, but a StyleSheet keeps the needed information. Also added setting the needed StyleSheet at the temporary object. AW: Looking now for all places using getSdrPageProperties() to set the items there; there seems to be an error there, too... AW: Indeed, in fupage.cxx (sd) in FuPage::ApplyItemSet at the end, the attributes get set for the page directly even when set to all is choosen. I think this should happen at the end of FuPage::ExecuteDialog (where all other itemset changes are applied and it is known what to do). Have to ask SD'lers to make sure... Created attachment 70170 [details]
Patch to fix the main task
AW: Added patch to fix the visualisation. AW->CL: Please take over and take a look why attributes are set at the single page when 'apply to all' is used (sd/source/ui/func/fupage.cxx ln 590). *** Issue 112650 has been marked as a duplicate of this issue. *** fixed in cws impress193 verified in cws, back to qa Verified in CWS. *** Issue 111121 has been marked as a duplicate of this issue. *** |