|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | sfx2: dock windows change position after restart of the app | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | dtardon <dtardon> | ||||||
| Component: | code | Assignee: | AOO issues mailing list <issues> | ||||||
| Status: | REOPENED --- | QA Contact: | |||||||
| Severity: | Trivial | ||||||||
| Priority: | P3 | CC: | arielch, eric.bachard, issues | ||||||
| Version: | OOo 3.2 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
Created attachment 70301 [details]
like this
Thanks for the patch, I will have a look set target to 3.x since not release relevant for 3.4 release. The patch required some minor adjustments. I also translated some debug messages while here. Sending sfx2/source/dialog/splitwin.cxx Transmitting file data . Committed revision 1195005. Thank you! 1. start impress 2. open navigator 3. dock it to the right of the right pane Crash. Created attachment 77071 [details]
patch to revert all changes
(In reply to comment #4) > The patch required some minor adjustments. > I also translated some debug messages while here. > > Sending sfx2/source/dialog/splitwin.cxx > Transmitting file data . > Committed revision 1195005. please revert all changes. It crashes AOO when docking any docking window by moving the window on the docking area (docking by holding down the Ctrl key, double-click a vacant area in the window, is not broken). Thank you Ariel! Feel free to revert it ... I have not been doing OO related stuff lately and I seem to have problems with subversion lately anyways. @Ariel Please keep the english comments. Nobody will understand the german one ;-) No crash for me on Mac OS X Intel (Tiger 10.4) I can dock, undock, dock undock the navigator everywhere. Hi Eric; The obvious question .. If we revert this change do you have issues docking in OS X? (In reply to comment #5) > 1. start impress > 2. open navigator > 3. dock it to the right of the right pane > Crash. A crash dump, if you can get one, would be good. The patch was reverted in r1214137 by arielch. I do prefer to avoid the crash so this was well done. The German comments are back too but quite honestly the translator that someone ran didn't do a good job there. I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob Reset assigne to the default "issues@openoffice.apache.org". |
Steps to reproduce: 1. start impress 2. open navigator 3. dock it to the right of the right pane 4. quit impress 5. start writer 6. open styles and formatting 7. move it on top of the navigator to be docked (it should show as docked over the navigator) 8. grab the styles and formatting dock and move it down to dock it under the navigator 9. quit writer 10. start writer 11. the docks are side by side with the styles and formatting on the left The trouble is all applications have common configuration for the docks, so there are docks that are not visible in some applications (like impress's right pane in writer). These are still present in the array of docks, but their pWin member is NULL. So, in this case, the styles and formatting dock gets inserted to the dock array _after_ the (null) right pane. The attached patch changes behaviour of SfxSplitWindow::InsertWindow to insert a new dock before all null docks preceding the found insertion position.