Issue 113048

Summary: imported controlnames can be overidden by data in module source
Product: Calc Reporter: noel.power
Component: codeAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Trivial    
Priority: P3 CC: daniel.rentz, issues
Version: DEV300m84   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
patch file none

Description noel.power 2010-07-09 12:14:54 UTC
Sometimes in excel you will see a name of a control that is not the same as what
is in the binary format. In that case the names seems to be overridden by
attributes specific in the module preamble ( e.g. the section containing the
attributes ) Probably this is the specific codename which *can* apparently be
different from the control name of a shape/control object ( note: I *never*
succeeded in making the control name / code name different from each other )

sorry no test document either ( confidential ) ... although I think it may be
possible to get rid of any sensitive data in this case ( at least I will try )
Comment 1 noel.power 2010-07-09 12:15:29 UTC
Created attachment 70468 [details]
patch file
Comment 2 noel.power 2010-07-09 12:24:15 UTC
added to cws container_controls
Comment 3 daniel.rentz 2010-08-10 18:21:56 UTC
dr->noel: I have just seen that Excel 2007 does not use the control names from
the VBA project anymore, also when reading XLS files. The shape name always wins
here.

So, question is, do we really need to add a "fix" that has vanished in newer
Excel versions?
Comment 4 noel.power 2010-08-12 09:20:15 UTC
>So, question is, do we really need to add a "fix" that has vanished in newer
Excel versions?
Works at least in MSO2003, I don't have MSO2007 to test with, regardless I don't
think most customers are on MSO2007, I would say mostly they are on earlier
versions and want to move to openoffice ( and expect the best fidelity possible
) Mostly I would agree supporting stuff that no longer works in later versions
is a good idea but in this case the bug is serious enough ( it breaks macro
bindings for controls ) that going the extra mile is worth it ( btw I have come
across this 3 separate times from different customer documents ) Up to you if
you want to reject the patch
Comment 5 daniel.rentz 2010-08-12 09:27:40 UTC
Oops, yes I was talking about XL2007. Just wanted to hear your opinion. Yes I
think it is true that the there are a lot of customers out there with XL <= 2003
so I do not see a reason not to apply this patch ;)
Comment 6 noel.power 2010-08-12 10:00:38 UTC
>Mostly I would agree supporting stuff that no longer works in later versions
>is a good idea
is NOT a good idea
   ^^^
is what I meant
Comment 7 Rob Weir 2013-03-11 15:05:44 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob