Issue 113096

Hi,

I change the summary. Was "Optionpage of deinstalled extension stays visible"

Reason is clear:
 - install an extension that has a main menu entry
 - new document
  > menu entry is vissible
 - uninstall the extension
 - close all documents and start new one
 > menu is still there
This is wrong.
Only after restart of the office, the menu is gone.

can this pls be considered for 3.3.0 or at least 3.3.1?

.

jsc -> sb: this is indeed a regression and it works in OOo 3.2.1. It probably
depends on the changes in the config manager and we should fix it if possible
for OOo 3.3.

thanks jsc!
maybe experience from cd (issue 110127) could be helpful?

Apparently, with old configmgr implementation,
desktop/source/deployment/registry/configuration/dp_configuration.cxx called
m_defaultProvider->refresh() after removing extension .xcu files (effectively
removing the information provided by those files), while with the new configmgr
implementation it does nothing.

Fixed as <http://hg.services.openoffice.org/cws/sb130/rev/124b9f7d8f67>.

Technically, the new implementation no longer uses
com.sun.star.util.XRefreshable to update the configmgr database when an
extension xcu file is removed, but instead new
com.sun.star.configuration.XUpdate.removeExtensionXcuFile.  This has some
limitations:

- A heuristic (which is not perfect) is used to remove exactly the data that was
introduced by the xcu file, without loosing data that was either (a) defined in
lower layers and would now shine through or (b) defined in higher layers to
modify the existing data.  See
<http://hg.services.openoffice.org/cws/sb130/file/124b9f7d8f67/configmgr/source/components.cxx#l281>
for details.

- Extensions that were registered in an OOo installation before that
installation is upgraded to OOo 3.3 can have minor problems when being removed
now.  The first time such an extension is removed, life-removing the
corresponding xcu data does not work (i.e., this issue's bug occurs, and the
extension's option pages and menus stay visible until next OOo start).  After
the next OOo start, removal of any remaining old extensions works correctly.

@tm: please verify

Previous fix turned out to be incomplete, now completed with

- <http://hg.services.openoffice.org/cws/sb130/rev/a50994b1e5e7> "sb130:
#i113096# fixed TODO in configmgr::Broadcaster::send (to ease debugging)"

- <http://hg.services.openoffice.org/cws/sb130/rev/bd3f8dcba1fe> "fwk154:
i114090: adapt listener code to reflect changes in config mgr, notification of
change events (transplanted from 7c0cad639e0b6d74f4be88f5877270f1a8b9fa53)"

- <http://hg.services.openoffice.org/cws/sb130/rev/28375950cd24> "sb130:
#i113096# previous change contained an error in
configmgr::Components::removeExtensionXcuFile"

- <http://hg.services.openoffice.org/cws/sb130/rev/b27a6b6d67f1> "sb130:
#i113096# UniversalContentBroker::changesOccurred is now also called for removed
items"

- <http://hg.services.openoffice.org/cws/sb130/rev/ec02263f17a5> "sb130:
#i113096# previous configmgr::Components::removeExtensionXcuFile changes were
still not good"

Verified with cws sb130 = OK
NOTE: Only a side pane from the extension is left. SB told me that it is not
part of the regression.
Workaround: Close and restart OOo
I'll file a additional issue for that.

Follow up issue 114151