Issue 113411

Summary: Cell number formatting lost in data pilot table if source data starts with
Product: Calc Reporter: nardoia <gianni.nardoia>
Component: formattingAssignee: kla <thomas.klarhoefer>
Status: CLOSED FIXED QA Contact: issues@sc <issues>
Severity: Trivial    
Priority: P3 CC: cno, issues, nesshof, rainerbielefeld_ooo_qa
Version: OOo 3.2.1Keywords: oooqa, regression
Target Milestone: 3.4.0   
Hardware: Unknown   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
Pls. see comments from rainerbielefeld Mon Jul 26 05:06:51
none
data pilot test none

Description nardoia 2010-07-25 19:40:10 UTC
hello, 
when refreshing data pilot table, column formatting is lost. This has been
verified in previous version too.
bye, gianni
Comment 1 Rainer Bielefeld 2010-07-26 06:06:51 UTC
Reproducible with "Ooo-Dev 3.3 multilingual version German UI WIN XP: [DEV300m84
(Build 9512)]"! Same with German UI.

Steps to reproduce:
0. open attached "sample.ods" from testkit zip
1. change to sheet "Datenpilot_Sheet1_1" if necessary
2. right click 'C14'
3. select in context menu 'Refresh'
   expected: value formatting from data source "Tabelle1" (EUR) should remain
   actual: No. of decimal places and currency formating lost.

You will also get a column without formatting when you create a new data pilot
table following instruciton from "screenshots.PDF" for "Tabelle1.A1:F214"

@nardoia:
What OS/Platform did you test?
Comment 2 Rainer Bielefeld 2010-07-26 06:29:51 UTC
Created attachment 70810 [details]
Pls. see  comments from rainerbielefeld Mon Jul 26 05:06:51
Comment 3 Rainer Bielefeld 2010-07-26 06:37:08 UTC
Worked fine with Ooo 3.1.1 WIN XP DE[OOO310m19 (Build 9420)]", "2.4.1 
Multilingual version English UI WIN XP: [680m17(Build9310)]".
Comment 4 Rainer Bielefeld 2010-07-26 06:42:26 UTC
Related to Issue 94186?
Comment 5 nardoia 2010-07-26 18:26:39 UTC
I'm testing Ubuntu (Ooo3.2.0-en) and xp platforms (Ooo3.2.1-en). Related to my
problem, Ooo has the same problems on both... 
Your sample.ods work fine 
No. of decimal places and currency formating NOT lost.
Comment 6 Rainer Bielefeld 2010-07-26 19:10:41 UTC
@nardoia:
Did I really reproduce YOUR problem? Can you please contribute a sample document?
Comment 7 nardoia 2010-07-27 04:55:08 UTC
Created attachment 70838 [details]
data pilot test
Comment 8 nardoia 2010-07-27 04:58:12 UTC
the column "c" should be "date".
Comment 9 Rainer Bielefeld 2010-07-27 05:24:22 UTC
Also reproducible with nardoia's "test.ods" and "Ooo-Dev 3.3.0 multilingual
version English UI WIN XP: [DEV330m1 (Build 9514)]"!
Problem also visible in my own sample documents and Build 9514) - strange.

I believe this one is a 3.3.0 blocker
Comment 10 niklas.nebel 2010-07-27 18:41:12 UTC
There are two unrelated effects:

In test.ods, the cell style "DataPilot Category" has a number format set. In
that case, the style's format is used. See also issue 89493.

In sample.ods the format isn't recognized because of the empty cells at the
start of the data range. This is new since DEV300m76 and should probably be fixed.
Comment 11 Rainer Bielefeld 2010-07-28 05:36:11 UTC
I can confirm  nn's observations. Reported problem shown with "test.ods" also is
reproducible for me with 3.1.1, problem shown with "sample.ods" works fine with
3.1.1, so there can't be a common root.

And indeed, deleting empty lines 2-4 in "sample.ods" repairs the problem.

My suggestions for further proceeding:
- Problem from original report is already covered with Issue 89493, so we 
 should ignore it here.
- I can't find any other report for the problem with "sample.ods", so we should 
  use this issue 113411 for that problem, new Subject 
  "Cell number formatting lost in data pilot table if source data starts with 
   empty lines"
Because of the simple workaround I do no see Issue 113411 as a 3.3 blocker.

Any objections?
Comment 12 Rainer Bielefeld 2010-07-28 10:31:28 UTC
No objections, so I will proceed as suggested.

@nardoia:
Thank you for your attention
Comment 13 niklas.nebel 2011-02-16 12:22:43 UTC
Fixed in CWS "calc66".
Comment 14 ooo 2011-02-17 15:48:19 UTC
Code change reviewed.
Comment 15 niklas.nebel 2011-03-15 14:35:25 UTC
Reassigning to QA for verification.
Comment 16 kla 2011-03-21 09:46:09 UTC
Seen ok in cws calc66 -> verified