Issue 115820

Summary: Charts are garbled in attached pptx
Product: Impress Reporter: kpalagin <kpalagin>
Component: open-importAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Trivial    
Priority: P3 CC: bo.tian, companycy, gavmgaurav, issues, tmyl2010
Version: OOo 3.2.1   
Target Milestone: ---   
Hardware: All   
OS: All   
See Also: https://issues.apache.org/ooo/show_bug.cgi?id=124669
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
problematic file
none
patch
none
new patch
none
patch
bo.tian: review?
patch from TangMeng none

Description kpalagin 2010-11-29 07:34:32 UTC
Please open attached .pptx - starting at slide 3 it contains charts. Impress 
(either 3.2.1 or m94) does not display charts properly. Resaving to .ppt using 
PPT2003 produces file that Impress can open just fine.
Comment 1 kpalagin 2010-11-29 07:36:55 UTC
Created attachment 75158 [details]
problematic file
Comment 2 wolframgarten 2010-11-29 08:26:49 UTC
Reproducible in m93. Reassigned.
Comment 3 Bo.Tian 2012-09-06 08:47:51 UTC
Created attachment 79318 [details]
patch
Comment 4 bjcheny 2012-09-06 09:07:12 UTC
Please check my comment on patch in bug 119716, since it breaks build in chart2 module.
(In reply to comment #3)
> Created attachment 79318 [details]
> patch
Comment 5 Bo.Tian 2012-09-07 01:26:09 UTC
(In reply to comment #4)
> Please check my comment on patch in bug 119716, since it breaks build in
> chart2 module.
> (In reply to comment #3)
> > Created attachment 79318 [details]
> > patch

I delete the patch until I solve the build problem.
Comment 6 Tang Meng 2012-09-07 02:21:45 UTC
I have a patch, it's only used for pptx chart.
And I maybe commit patch on next Monday.
I have tested some pptx files.
Do you want to have a look?
I want to know your detailed solution.
I am glad to discuss with you. Ths.
Comment 7 Bo.Tian 2012-09-07 02:25:31 UTC
(In reply to comment #6)
> I have a patch, it's only used for pptx chart.
> And I maybe commit patch on next Monday.
> I have tested some pptx files.
> Do you want to have a look?
> I want to know your detailed solution.
> I am glad to discuss with you. Ths.

It just stopped at  ChartConverter::createDataSequence(), which should return a good converted XDataSequence.
So I get a single row data and convert it ,call InternalDataProvider::createDataSequenceByRangeRepresentationAndRole() handle it.
And lcl_createDataSequenceAndAddToMapByRole() will do the last work, make a row data into single ones and make it a chart data source.

And I add a boolmark to struct DataSequenceModel,to mark if a double value should be imported as category.Then the Date format can work.
Comment 8 Bo.Tian 2012-09-07 08:00:03 UTC
Created attachment 79349 [details]
new patch
Comment 9 Bo.Tian 2012-09-13 03:42:05 UTC
Created attachment 79457 [details]
patch
Comment 10 bjcheny 2012-09-13 05:18:24 UTC
Hi, I don't see any reason or comments on why you delete previous patch.

Would you please give comments on your action, including your deletion, or update patch? 
Then we can track your status/progress on the fix.

(In reply to comment #9)
> Created attachment 79457 [details]
> patch
Comment 11 Bo.Tian 2012-09-13 05:49:04 UTC
(In reply to comment #10)
> Hi, I don't see any reason or comments on why you delete previous patch.
> 
> Would you please give comments on your action, including your deletion, or
> update patch? 
> Then we can track your status/progress on the fix.
> 
> (In reply to comment #9)
> > Created attachment 79457 [details]
> > patch

sorry for that.
my working copy is too old when i make patch.
the previous two patch can't work on the latest code.(compile problem)
try this one.
hope everything will be ok.
Comment 12 Tang Meng 2012-10-08 07:20:52 UTC
Created attachment 79744 [details]
patch from TangMeng

Two new files are in this patch.
They are pptchartconverter.hxx and pptchartconverter.cxx
Comment 13 Gaurav Aggarwal 2013-07-10 12:16:36 UTC
I have applied your patch but still graphs are missing in PPTX.

Pl suggest