Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [WW8] bookmark export loops | ||||||
---|---|---|---|---|---|---|---|
Product: | Writer | Reporter: | mst.ooo | ||||
Component: | save-export | Assignee: | michael.ruess | ||||
Status: | CLOSED FIXED | QA Contact: | issues@sw <issues> | ||||
Severity: | Trivial | ||||||
Priority: | P2 | CC: | bjoern.michaelsen, issues, openoffice, vmiklos | ||||
Version: | DEV300m95 | ||||||
Target Milestone: | 3.4.0 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
mst.ooo
2010-12-21 12:35:46 UTC
Hm, I thought ca790fbee1db by OS alraedy fixed this. Is the document reproducing the issue public? @vmiklos: it looks like i have this revision in my version here, with this comment: GetSortedBookmarks: don't insert bookmarks from different nodes so it's a different problem :) the document does not really exist, it is dynamically created by the CheckBookmarks test. you can run it by starting an OOo like this: > DISPLAY=:5 ./soffice "-accept=pipe,name=$USER;urp;" -norestore then cd into sw/qa/complex/writer and run the test: > OOO_SUBSEQUENT_TESTS=t OOO_TEST_SOFFICE="connect:pipe,name=$USER" dmake i have hacked up something that makes it not loop, now i get lots of assertions instead; i'll attach the patch... (having no idea how this WW8 contraption works, and hbrinkm already on vacation...) Created attachment 75386 [details]
workaround
The loop is fixed in cws os156 in sw/source/filter/ww8/wrtw8nds.cxx There is still an error reported from the test: 1) checkBookmarks(complex.writer.CheckBookmarks) java.lang.AssertionError: expected:<336129041068093585184822036889681886625795355984> but was:<-5262733394391 167343036575832159781436> *** Issue 115908 has been marked as a duplicate of this issue. *** @os: IIRC with the workaround i got a successful run of the checkBookmarks (but that was of course before vacation...). if your fix gets an assertion, then i'm afraid probably the fix is wrong? some investigation reveals: the CheckBookmarks test does run with the fix by os on linux. the test fails also in a DEV300m90 build on windows. it fails when checking the inserted paragraph breaks, not on the WW8 file. test is running without error now Oliver, Hm, is os156 public? I don't see it listed at http://hg.services.openoffice.org/ Thanks, Miklos (who was just curious about what was the fix) @vmiklos: that was a typo, the CWS is actually os146, not os156! the changeset is this one: http://hg.services.openoffice.org/cws/os146?cmd=changeset;node=9475b9d2a2dc Oh, I see. Thanks for the pointer! Verified issue in CWS os146. |