Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Printer properties ignored from macros | ||
---|---|---|---|
Product: | General | Reporter: | andrew |
Component: | code | Assignee: | Oliver-Rainer Wittmann <orw> |
Status: | CLOSED FIXED | QA Contact: | issues@framework <issues> |
Severity: | Normal | ||
Priority: | P3 | CC: | issues, Mathias_Bauer, mdxonefour, oliver.brinzing, orw, philipp.lohmann |
Version: | OOo 3.3 | Keywords: | regression |
Target Milestone: | 3.4.0 | ||
Hardware: | PC | ||
OS: | Linux, all | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
andrew
2011-04-09 14:31:35 UTC
Side note: I also tested against 3.4 alpha. I took a look at sw/source/ui/uno/unotxdoc.cxx and it looks like this modifies this structure then puts it back. const SwPagePreViewPrtData* pData = pDocShell->GetDoc()->GetPreViewPrtData(); At that point, I stopped tracing the code. , @ hi: Please have a look. @od: I think this might have broken with the print changes in 3.3 in writer, could you please have a look ? adding keyword "regression" Just a question: I don't get from the description since when this problem exists; I had a look at the code and from what I saw it is not surprising that the macro doesn't work: the settings are just ignored. I browsed the source code of 3.2 and couldn't spot any important difference in that area; so before I dive deeper into that, I would like to know: which is the last OOo version that is known to execute the macro properly? the print settings are ignored since the introduction of the new printing. a fix for this issue is available and will be committed soon. fixed in cws sw34bf06 - changed files: sw/inc/unotxdoc.hxx, sw/source/ui/uno/unotxdoc.cxx, sfx2/source/view/viewprn.cxx, vcl/inc/vcl/print.hxx, vcl/source/gdi/print3.cxx, vcl/source/window/printdlg.cxx, change set http://hg.services.openoffice.org/cws/sw34bf06/rev/766a0b3ad79f od->pl/mba: one of you, please review the fix forgot to adjust the issue status Reviewed, ok for me Reviewed, looks OK for me too. Though checking only the first three characters of a parameter name looks a bid hackish. mba, you asked when this last worked..... I last tested with working code in late 1.x or early 2.x versions. Note that the original report claims that it worked five years ago. Some items stopped working (I believe) when the new print dialog was introduced, but, I don't remember if that was this particular code. Thanks Andrew; as Oliver already fixed the issue, we don't need to know more about that. getting rid of value "enhancement" for field "severity". For enhancement the field "issue type" shall be used. |