|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | glib build breaks on wntmsc. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | gsl | Reporter: | tono <t_ono> | ||||
| Component: | code | Assignee: | kurt.zenker | ||||
| Status: | CLOSED FIXED | QA Contact: | issues@gsl <issues> | ||||
| Severity: | Major | ||||||
| Priority: | P1 (highest) | CC: | hans-joachim.lankenau, issues, ooo | ||||
| Version: | current | ||||||
| Target Milestone: | 3.4.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||
| Developer Difficulty: | --- | ||||||
| Attachments: |
|
||||||
add hjs to CC I just build glib with the patch applied, and had no problems, so the patch should be OK I guess. I wonder however why $(GNUCOPY) shouldn't work, don't we use that all over the place ? Moreover I can't help but wonder how it compiles here without the patch then. @pl: Because nmake cannot invoke command with posix absolute path starting with '/', $(GNUCOPY) is only used in makefiles for dmake or gnu make and not in makefiles for nmake, I think. turns out that in our environmen $(GNUCOPY) is simply "cp" instead of "/usr/bin/cp" which explains why it did not fail here. @kz: as this is a build breaker for OOo, could you please apply this as masterfix ? The patch has been applied as masterfix for OOO340m1. |
Created attachment 76332 [details] Patch to fix the issue In local patches for wntmsc build of glib, copy commands in makefiles are substituted with environment variable macro $(GNUCOPY). It includes posix path notation and cannot be invoked from Microsoft nmake. Additionally, glib maintainer uses "for" command loop in makefiles. It is dangerous because the return code status may be lost. And last but not least, the path specifications of glibconfig.h are wrong in the top-level makefile.msc.