Issue 119161

Summary: Regression: Writer set table border's line style like "none" during import from .docx
Product: Writer Reporter: sorath <torokhov-s-a>
Component: open-importAssignee: AOO issues mailing list <issues>
Status: CLOSED FIXED QA Contact:
Severity: Normal    
Priority: P3 CC: binbjguo, doudou1976, jsc, pescetti, polo8495, torokhov-s-a, wujinlong
Version: 3.4.0Keywords: regression
Target Milestone: 3.4.1Flags: jsc: 3.4.1_release_blocker+
Hardware: PC   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Description Flags
OpenXML_text_reference_v1_2.docx (prepared with MS 2007 Office)
for compare: OpenXML_text_reference_v1_2.pdf
fix none

Description sorath 2012-04-01 00:39:28 UTC
Created attachment 77392 [details]

It is a Regression for Apache OpenOffice 3.4.0 compare with 3.3.0

Open attached file "test_2010.docx" in the AOO 3.4.0. Note that table on the second page dipsplay like with "none" table border style (verify it with Page Preview), 

Now open attached docx-file in 3.3.0 and note that table borders are displayed correct.

See attached "test_2010.pdf" to reference how table (and whole doumenet) must looks in MS Office 2010 and "test_2010_OOo-3.3.0.pdf" for how table is displayed in 3.3.0
Comment 1 sorath 2012-04-01 00:40:03 UTC
Created attachment 77393 [details]
Comment 2 sorath 2012-04-01 00:40:27 UTC
Created attachment 77394 [details]
Comment 3 sorath 2012-04-01 00:50:25 UTC
Sorry, "test_2010.pdf" attached file for reference how "test_2010.docx" is displayed in MS Office 2010 but however it contains wrong displaying of formulas (error of MS Office PDF export), but table is displayed correct.
Overall correct PDF is 1.2 mb and I'm not able to download it to bug tracker due to filesize limitation by 1 mb.
Comment 4 sorath 2012-04-01 06:30:10 UTC
Created attachment 77399 [details]
OpenXML_text_reference_v1_2.docx (prepared with MS 2007 Office)

One more .docx test file (taken from that was obvious prepared with MS Office 2007 and were the same regression is observed.
Comment 5 sorath 2012-04-01 06:32:06 UTC
Created attachment 77400 [details]
for compare: OpenXML_text_reference_v1_2.pdf
Comment 6 sorath 2012-04-02 16:10:14 UTC
This regression is also observed in OOo-dev 3.4.0 - OOO340m Build:9583 (Oracle 3.4 beta) released on 11.04.2011
Comment 7 Andrea Pescetti 2012-05-20 13:45:37 UTC
Confirming and setting regression with respect to 3.3.0. Adding "?" in the 3.4.1_release_blocker as requested on ooo-dev.
Comment 8 zhao xia 2012-05-28 05:55:00 UTC
Move the version to AOO341
Comment 9 Marcus 2012-05-28 09:35:46 UTC
Changed back to AOO340:

Version: This field is to show the version where the problem has occurred first.
Target: This field is to set the release where the problem should be fixed.
Comment 10 wujinlong 2012-06-04 08:52:35 UTC
I'm looking into this bug now.
Comment 11 wujinlong 2012-06-04 09:40:59 UTC
Created attachment 77938 [details]

This is the fix. 

Solution is to copy the sStyleIdentifierI and sStyleIdentifierD variables from StyleSheetEntry when constructing a new TableStyleSheetEntry object. Otherwise, FindStyleSheetByISTD() will fail to find the table style, and so the border property will not be applied properly.
Comment 12 jsc 2012-06-04 14:05:59 UTC
Patched reviewed, tested and applied in AOO34 and trunk

AOO34 -> revision 1345975
trunk -> revision 1345976
Comment 13 jsc 2012-06-06 10:04:11 UTC
set release blocker flag for 3.4.1
Comment 14 binguo 2012-06-19 05:56:16 UTC
Verified it on Aoo_Trunk_20120616.1800.1350879 and it does not reproduce, so close it as fixed.
Comment 15 Terry Yang 2012-06-26 06:26:27 UTC
Verify fixed on AOO 3.4.1 DEV snapshot  1351960 and Trunk rev.1351712
Comment 16 jsc 2012-07-25 09:11:34 UTC
set target milestone AOO 3.4.1