|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Regression: Writer set table border's line style like "none" during import from .docx | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Writer | Reporter: | sorath <torokhov-s-a> | ||||||||||||||
| Component: | open-import | Assignee: | AOO issues mailing list <issues> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||||
| Severity: | Normal | ||||||||||||||||
| Priority: | P3 | CC: | binbjguo, doudou1976, jsc, pescetti, polo8495, torokhov-s-a, wujinlong | ||||||||||||||
| Version: | 3.4.0 | Keywords: | regression | ||||||||||||||
| Target Milestone: | 3.4.1 | Flags: | jsc:
3.4.1_release_blocker+
|
||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||||||
| Developer Difficulty: | --- | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 77393 [details]
test_2010.pdf
Created attachment 77394 [details]
test_2010_OOo-3.3.0.pdf
P.S. Sorry, "test_2010.pdf" attached file for reference how "test_2010.docx" is displayed in MS Office 2010 but however it contains wrong displaying of formulas (error of MS Office PDF export), but table is displayed correct. Overall correct PDF is 1.2 mb and I'm not able to download it to bug tracker due to filesize limitation by 1 mb. Created attachment 77399 [details] OpenXML_text_reference_v1_2.docx (prepared with MS 2007 Office) One more .docx test file (taken from http://katana.oooninja.com/w/reference_sample_documents) that was obvious prepared with MS Office 2007 and were the same regression is observed. Created attachment 77400 [details]
for compare: OpenXML_text_reference_v1_2.pdf
This regression is also observed in OOo-dev 3.4.0 - OOO340m Build:9583 (Oracle OpenOffice.org 3.4 beta) released on 11.04.2011 Confirming and setting regression with respect to 3.3.0. Adding "?" in the 3.4.1_release_blocker as requested on ooo-dev. Move the version to AOO341 Changed back to AOO340: Version: This field is to show the version where the problem has occurred first. Target: This field is to set the release where the problem should be fixed. I'm looking into this bug now. Created attachment 77938 [details]
fix
This is the fix.
Solution is to copy the sStyleIdentifierI and sStyleIdentifierD variables from StyleSheetEntry when constructing a new TableStyleSheetEntry object. Otherwise, FindStyleSheetByISTD() will fail to find the table style, and so the border property will not be applied properly.
Patched reviewed, tested and applied in AOO34 and trunk AOO34 -> revision 1345975 trunk -> revision 1345976 set release blocker flag for 3.4.1 Verified it on Aoo_Trunk_20120616.1800.1350879 and it does not reproduce, so close it as fixed. Verify fixed on AOO 3.4.1 DEV snapshot 1351960 and Trunk rev.1351712 set target milestone AOO 3.4.1 |
Created attachment 77392 [details] test_2010.docx It is a Regression for Apache OpenOffice 3.4.0 compare with OpenOffice.org 3.3.0 Open attached file "test_2010.docx" in the AOO 3.4.0. Note that table on the second page dipsplay like with "none" table border style (verify it with Page Preview), Now open attached docx-file in OpenOffice.org 3.3.0 and note that table borders are displayed correct. See attached "test_2010.pdf" to reference how table (and whole doumenet) must looks in MS Office 2010 and "test_2010_OOo-3.3.0.pdf" for how table is displayed in OpenOffice.org 3.3.0