Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony] AOO crash if a connector which connected to PPT table | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | liuping <doneyourself> | ||||||||
Component: | open-import | Assignee: | AOO issues mailing list <issues> | ||||||||
Status: | CLOSED FIXED | QA Contact: | |||||||||
Severity: | Major | ||||||||||
Priority: | P1 (highest) | CC: | awf.aoo, liushenf, louqingle, rb.henschel, sunyingshadesun | ||||||||
Version: | 3.4.0 | ||||||||||
Target Milestone: | 4.0.0 | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||
Developer Difficulty: | --- | ||||||||||
Attachments: |
|
Created attachment 77688 [details]
capture.png
Duplicate to your own issue 119433 *** This issue has been marked as a duplicate of issue 119433 *** because bug 119433 don't reproduce ,so reopen this defect reproduce this defect on win7-64bit again on version 1354891 I'm checking this defect. the step of creating the sample file: insert a table and a connector in symphony and save as .ppt file
> sample file
>
> 1.open the sample file in MS and in AOO
>
> 2. Display normally in MS (table connected by a connector)
>
> Defect:
>
> crash in AOO
root cause: reference null point. Solution: In MS, the one_row_one_col table is made up of five shape,the connector is connected to some part of a table. but in AOO, the connector is connected to the whole group table,so the connector obj is a group table when export by AOO,should process this situation when import. in file "main\filter\source\msfilter\svdfppt.cxx": in function: SdrPowerPointImport::CreateTable( ) at line 7738. The table object is created by a group object,then release the group object pointer. when a connector connect to a group object pointer created by AOO export, and the group object pointer has been release in line 7846,but the connector solver still use the pointer,so crash occur. There are a solution which replace the group object's pointer with new table object pointer. Created attachment 78631 [details]
patch for ppt import table connectd by connector crash
"af" committed SVN revision 1360632 into trunk: #i119493# Fixed import of tables with connectors. Comment on attachment 78631 [details]
patch for ppt import table connectd by connector crash
Reviewed and tested: OK
Fixed. Verified pass on Windows7-64bit, Redhat 32bit,ubutu 10.04 Mac10.7 with AOO trunk r1374181 verified on XP SP3, win7, win7 64-bit, Vista, Ubuntu 12.04, Redhat 6.1, suse 11 sp1, suse 11 sp1 64-bit in trunk build 1376366, pass. Close this bug |
Created attachment 77687 [details] sample file 1.open the sample file in MS and in AOO 2. Display normally in MS (table connected by a connector) Defect: crash in AOO