Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Calc | Reporter: | Shan Zhu <shanzhu33> | ||||||
Component: | open-import | Assignee: | zhang jianfang <zhangjf> | ||||||
Status: | CLOSED FIXED | QA Contact: | |||||||
Severity: | Major | ||||||||
Priority: | P3 | CC: | companycy, tldyzem, zhangjf | ||||||
Version: | 3.4.0 | ||||||||
Target Milestone: | 4.0.0 | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Verified in AOO3.4.1_r1354891. Change status into Confirmed. Created attachment 79199 [details]
patch for blank item in page filter from pivot table in xlsx
Sometimes, it's possible for page filter to select empty field.
Thus, it's unnecessary to limit value for page filter to be not NULL.
However, I strongly suggest some string in UI like "empty" to indicate that "empty" is selected as page filter. It helps user understand this. Review comments: In the patch, does aSelectedPage has other scenario that will be null string besides empty field be selected? if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem( nCacheItem ) ) { OUString aSelectedPage = pSharedItem->getName(); OUString aSelectedPage = pSharedItem->getName(); aPropSet.setProperty( PROP_SelectedPage, aSelectedPage ); } Not found so far based on current knowledge. (In reply to comment #4) > Review comments: > > In the patch, does aSelectedPage has other scenario that will be null string > besides empty field be selected? > > if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem( > nCacheItem ) ) > { > > OUString aSelectedPage = pSharedItem->getName(); > OUString aSelectedPage = pSharedItem->getName(); > aPropSet.setProperty( PROP_SelectedPage, aSelectedPage ); > } (In reply to comment #5) > Not found so far based on current knowledge. > > > (In reply to comment #4) > > Review comments: > > > > In the patch, does aSelectedPage has other scenario that will be null string > > besides empty field be selected? > > > > if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem( > > nCacheItem ) ) > > { > > > > OUString aSelectedPage = pSharedItem->getName(); > > OUString aSelectedPage = pSharedItem->getName(); > > aPropSet.setProperty( PROP_SelectedPage, aSelectedPage ); > > } Thx, I think it's ok to fix as it. "zhangjf" committed SVN revision 1383888 into trunk: #i119512#, when importing MS Excel, if there is blank item selected in page f... Change to resolved state |
Created attachment 77713 [details] .xlsx file with blank item in Page field of Pivot table Build info: AOO3.4_r1327774 Open the .xlsx sample file attached in AOO. (In the sample file, the "(blank)" item has been selected in Page fields of 3 Pivot tables) Defect: All the selection in Page field will be changed into "All" after importing .xlsx into AOO. The Page field can not support the "blank" item in it.