|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [From Symphony] Function "Case sensitive" in "Special Filter" dialog can not work. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Calc | Reporter: | binguo <binbjguo> | ||||||||
| Component: | code | Assignee: | AOO issues mailing list <issues> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | Normal | ||||||||||
| Priority: | P3 | CC: | clarence.guo.bj, leiw, liushenf, polo8495 | ||||||||
| Version: | 3.4.0 Beta (OOo) | ||||||||||
| Target Milestone: | 4.0.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||
| Developer Difficulty: | --- | ||||||||||
| Attachments: |
|
||||||||||
The special filter means "advanced filter" I think. I'm working on this issue Created attachment 78735 [details]
patch
Root Cause:
In method ScTable::CreateExcelQuery, the filter string was converted to capital, no matter case sensitive or case insensitive. But after that, it will use case sensitive to compare the string according to the bCaseSensi flag of rQueryParam(already set to true)
Solution:
Don't convert string. It's redundant because later all comparisons will be performed according to bCaseSensi flag of rQueryParam
Created attachment 78737 [details]
patch
Root Cause:
In method ScTable::CreateExcelQuery, the filter string was converted to capital, no matter case sensitive or case insensitive. But after that, it uses case sensitive to compare the strings according to the bCaseSensi flag of rQueryParam( was set to true )
Solution:
Don't convert string. It's redundant because later it will use bCaseSensi flag of rQueryParam for string comparison.
"leiw" committed SVN revision 1366302 into trunk: #i119637 Function "Case sensitive" in "Special Filter" dialog can not work. The patch looks good. Submitted in SVN revision 1366302 Comment on attachment 78735 [details]
patch
patch reviewed by Wang Lei
Comment on attachment 78737 [details]
patch
patch reviewed by Wang Lei
Verify not fixed on revision 1372282 with attached sample file. If we uncheck "Case sensitive" in the group "Options", it will fiter 2 result, but if we check "Case sensitive", no result get, we should get 1 result as expect. Sorry please ignore my last comments, this bug fixed on build revision 1374181. Close this bug set Target Milestone to AOO 3.5.0 for PM purpose. |
Created attachment 77863 [details] Sample file can repro this bug. Steps: 1. Open the sample file. 2. Special filter Month="February" and check "Case sensitive" in the group "Options" 3. Check the result of Specical Filter in SC editor Defect : No Correct result of Specical Filter show.