Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony]exit animation changed after save as ppt file to another ppt | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | Li Feng Wang <phoenix.wanglf> | ||||||||
Component: | editing | Assignee: | AOO issues mailing list <issues> | ||||||||
Status: | CLOSED FIXED | QA Contact: | |||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | CC: | lijianyuan1983, liushenf, steve.yin.aoo, sunying | ||||||||
Version: | 3.4.0 | ||||||||||
Target Milestone: | 4.0.0 | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||
Developer Difficulty: | --- | ||||||||||
Attachments: |
|
Description
Li Feng Wang
2012-06-04 07:58:03 UTC
I'm checking this defect. root cause: When saving the "Delay" value, the AnimationExporter::exportAnimEvent function use an uninitalized value eTiming. at line 1381 in file "\main\sd\source\filter\eppt\pptexanimations.cxx",the "if ( eTiming == Timing_INDEFINITE )" is always false, and the nBegin value never is assigned by fTiming. so the "Delay" value always is zero. solution: according in "\main\offapi\com\sun\star\animationstiming.idl", describe the indefinite of Timing: enum Timing { /** specifies that a duration, end or start time is indefinite*/ INDEFINITE, /** specifies a simple duration as the intrinsic media duration. This is only valid for elements that define media. */ MEDIA }; only and if only the eTiming is Timing_INDEFINITE, the animation has a fTiming, so the judgment "if ( eTiming == Timing_INDEFINITE )" is unnecessary. Created attachment 79327 [details]
patch for export animation delay
Created attachment 79330 [details]
UT file
*** Issue 120696 has been marked as a duplicate of this issue. *** Reviewed and tested. OK. Remove the unnecessary judgement. "sunying" committed SVN revision 1382623 into trunk: #119711# support the delay var when export ppt file by AOOReported by: Wang L... has been fixed Set Target Milestone to AOO 3.5.0 for PM purpose. |