Issue 119950

Summary: [Windows 8 certification]Test for "Section 11 Apps must support multi-user sessions" is not tested by Windows App Certification Kit.
Product: General Reporter: DaLi Liu <wawalovo>
Component: uiAssignee: AOO issues mailing list <issues>
Status: CLOSED FIXED QA Contact:
Severity: Blocker    
Priority: P3 CC: jsc, yuanlin.ibm, zhangjf
Version: 3.4.0Flags: jsc: 3.4.1_release_blocker+
Target Milestone: 3.4.1   
Hardware: PC   
OS: Windows 7   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 121359, 121372    
Attachments:
Description Flags
patch for warn and exit on multi terminal session case
none
new patch for warn and exit on multi terminal session case
none
Screen snapshot of the warning dialog in mutiple terminal session environment
yuanlin.ibm: review?
patch that only contains dialog string
none
new patch only contains dialog string
yuanlin.ibm: review?
updated patch for warn and exit on multi terminal session case
yuanlin.ibm: review?
Updated screen snapshot of the warning dialog none

Description DaLi Liu 2012-06-12 05:38:08 UTC
Comments given by Herbert1 for "11.7 Your app must check other terminal service (TS) sessions for existing instances of the app" : We need to rearchitect our IPC to TS session management.

----------------------------------------------------------------------
Related links:
Windows 8 Preview ISO image
http://windows.microsoft.com/en-US/windows-8/iso
Windows App Certification Kit
http://msdn.microsoft.com/en-us/windows/desktop/hh852363
Certification requirements for Windows 8 desktop apps
http://msdn.microsoft.com/library/windows/desktop/hh749939
----------------------------------------------------------------------

----------------------------------------------------------------------
Please see the wiki page for full test result.
http://wiki.services.openoffice.org/wiki/Documentation/Windows_App_Certification_Kit_-_Test_Results_for_Apache_OpenOffice_3.4
Comment 1 yuanlin 2012-06-14 07:59:27 UTC
Tested by Yan Ji on a Windows 2008 server. When allow one user to remote log in with multiple sessions, AOO 3.4 is not stable and will crash after some operations.  
To support multiple session for one user, I think rearchitect single IPC to TS session managment is not enough. If allow multiple AOO instance can be run isolated for one user, the data in user directory must be synchronized correctly such as extensions, .xcu and other configuration files. So I suggest that we use the simple way that do below mentioned in Certification requirements for Windows 8
"If an app does not support multiple user sessions or remote access, it must clearly state this when launched from this kind of session"
That is when AOO launched, check if there is another AOO instance is in another TS session for same user. If does, popup a warning dialog and exit.
Comment 2 yuanlin 2012-06-25 09:55:12 UTC
Created attachment 78463 [details]
patch for warn and exit on multi terminal session case

This patch use a trick way to detect if there is another soffice.bin instance launched by the same user but in another terminal session. One named pipe can be created many time with default parameters in mutli terminal session enabled env. 
So in officeipcthread.cxx, change the detect logic for SingleIPC named piped. Now will try to connect to an existing pipe first. If can be connected, then create it. It can not be created if the existing pipe is created in the same terminal session. But it can be created if the existing pipe is opened in another terminal session.
And other codes is used to pass the error code and show the error message.
Comment 3 yuanlin 2012-06-26 07:29:08 UTC
Created attachment 78481 [details]
new patch for warn and exit on multi terminal session case

Because the warning dialog will be displayed before Desktop::Main() method called. So can not use variable such as "%PRODUCTNAME" in the warning message. Do re-wording for the warning message in the new patch.
Comment 4 yuanlin 2012-06-26 08:03:01 UTC
Created attachment 78482 [details]
Screen snapshot of the warning dialog in mutiple terminal session environment

This warning dialog will be popup in below scenario:
1. A user login Windows Server and launch the openoffice from remote desktop terminal from local. Keep the openoffice running.
2. The user login the Windows server with same username in another terminal session. (The desktop is different from previous one)
3. The user launch openoffice from the new terminal session. The warning dialog will be opened.

Note: On Windows server 2008/2008R2, defautly one user can only have one terminal session. Below is a link to enable multiple terminal session for one user on Windows server 2008/R2
http://technet.microsoft.com/en-us/library/cc754762.aspx
Comment 5 yuanlin 2012-06-29 02:47:52 UTC
Created attachment 78520 [details]
patch that only contains dialog string

Add a patch that only add the string used by the warning dialog. It can be used for translation
Comment 6 yuanlin 2012-06-29 07:00:59 UTC
Created attachment 78521 [details]
new patch only contains dialog string

String is updated after ID review. So update the patch
Comment 7 zhang jianfang 2012-06-29 12:52:16 UTC
I have committed the string patch to AOO3.4.1 by revision r1355344 at first to catch up translation.
Comment 8 yuanlin 2012-07-02 05:26:46 UTC
Created attachment 78532 [details]
updated patch for warn and exit on multi terminal session case

Update the patch. Remove display the untranslated "Fatal Error" string on warning dialog title.
Comment 9 yuanlin 2012-07-02 05:28:53 UTC
Created attachment 78533 [details]
Updated screen snapshot of the warning dialog

Updated screen snapshot of the warning dialog. Remove "Fatal Error" string on dialog title.
Comment 10 jsc 2012-07-18 11:05:04 UTC
set release blocker flag
Comment 11 SVN Robot 2012-07-19 14:55:32 UTC
"jsc" committed SVN revision 1363359 into trunk:
#119950# introduce new warning message box to inform about further running te...
Comment 12 SVN Robot 2012-07-19 15:03:15 UTC
"jsc" committed SVN revision 1363360 into branches/AOO34:
#119950 merge fix from trunk
Comment 13 jsc 2012-07-20 09:08:04 UTC
patch reviewed and integrated in trunk and branch
Comment 14 jsc 2012-07-25 09:03:00 UTC
set target milestone AOO 3.4.1
Comment 15 Yan Ji 2012-11-30 06:38:36 UTC
Verified fixed in build r1400866,