Issue 120019

Summary: [From Symphony] There is a memory leak in function EmbeddedObjectRef::~EmbeddedObjectRef()
Product: performance Reporter: ChaoHuang <chao.dev.h>
Component: codeAssignee: AOO issues mailing list <issues>
Status: CLOSED FIXED QA Contact:
Severity: Normal    
Priority: P3 CC: hdu, issues, liushenf
Version: AOO 3.4.0   
Target Milestone: 4.0.0   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 120975, 121366    
Attachments:
Description Flags
for file "main\svtools\source\misc\embedhlp.cxx" hdu: review+

Description ChaoHuang 2012-06-18 07:00:30 UTC
Steps to reproduce the defect:
1) Launch Aoo3.4
2) New a odp file, save it
3) New a odt file, insert the odp file as an OLE object
4) Save the odt file, close it

Defect: There is a memory leak in function EmbeddedObjectRef::~EmbeddedObjectRef()
Comment 1 ChaoHuang 2012-06-18 07:03:46 UTC
The mpImp will be created in the constructor for class EmbeddedObjectRef. But it will not be released in destructor. Need to free it explicitly.
Comment 2 ChaoHuang 2012-06-18 07:14:08 UTC
Created attachment 78375 [details]
for file "main\svtools\source\misc\embedhlp.cxx"
Comment 3 hdu@apache.org 2012-06-19 10:02:03 UTC
Great find. The leak was probably introduced by a mis-pimpl-ification of the EmbeddedObjectRef class.
Applied as 1351632.
Comment 4 Yan Ji 2012-11-30 04:47:15 UTC
Since last SVT(r1400866) shows there is no memory leak, so close this defect as resolved.