Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [MemoryLeak]All GlobalAcceleratorConfiguration objects get leaked | ||||||
---|---|---|---|---|---|---|---|
Product: | General | Reporter: | zhang jianfang <zhangjf> | ||||
Component: | code | Assignee: | Andre <awf.aoo> | ||||
Status: | CLOSED FIXED | QA Contact: | |||||
Severity: | Major | ||||||
Priority: | P3 | CC: | awf.aoo, jsc, phoenix.wanglf | ||||
Version: | 3.4.0 | Flags: | jsc:
3.4.1_release_blocker+
|
||||
Target Milestone: | 3.4.1 | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Issue Depends on: | |||||||
Issue Blocks: | 120975, 121359, 121372 | ||||||
Attachments: |
|
Description
zhang jianfang
2012-06-19 05:54:34 UTC
Raise to a major problem. This in fact is a very serious problem, which cause many related objects get leaked too. ModuleAcceleratorConfiguration class has almost same piece of code, so it may also have this kinds of memory leaks, will confirm it late. Created attachment 78400 [details]
patch for globalacceleratorconfiguration object leak problem
The fix is to add XComponent interface implementation on XCUBasedAcceleratorConfiguration, it is inherited by both GlobalAcceleratorConfiguration and ModuleAcceleratorConfiguration. Then call it's dispose() API in ToolbarManager, MenuBarManager and moduleuiconfigurationmanager's dispose() api.
Here ModuleAcceleratorConfiguration.dispose() is not critical because it is rarely called, but for constancy it is also implemented.
This memory leak happens with very common use cases, includes when new/open a document it shows the toolbar, or mouse click to show the drop down menu... Many GlobalAcceleratorConfiguration referenced objects also leak too. So propose it to be a 3.4.1 candidate. Comment on attachment 78400 [details]
patch for globalacceleratorconfiguration object leak problem
Reviewed. Patch looks good.
Taking over for committing. Committed. SVN revision is 1352075. add MemoryLeak tag for this defect. This defect need Long running test to verify. set release blocker flag for 3.4.1 Merged from trunk into 3.4.1 by revision r1356536. set target milestone AOO 3.4.1 In last SVT(r1400866), no memory leak, so close this defect. |