|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [From Symphony] There is a memory leak in function SvXMLExportItemMapper::QueryXMLValue | ||||||
|---|---|---|---|---|---|---|---|
| Product: | performance | Reporter: | ChaoHuang <chao.dev.h> | ||||
| Component: | code | Assignee: | zhang jianfang <zhangjf> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | Normal | ||||||
| Priority: | P3 | CC: | liushenf, zhangjf | ||||
| Version: | AOO 3.4.0 | ||||||
| Target Milestone: | 4.0.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
| Developer Difficulty: | --- | ||||||
| Issue Depends on: | |||||||
| Issue Blocks: | 120975, 121366 | ||||||
| Attachments: |
|
||||||
Created attachment 78451 [details]
for file "main/sw/source/filter/xml/xmlexpit.cxx"
Need to free pWritingModeHandler explicitly Comment on attachment 78451 [details]
for file "main/sw/source/filter/xml/xmlexpit.cxx"
I will review it
Comment on attachment 78451 [details]
for file "main/sw/source/filter/xml/xmlexpit.cxx"
The fix works very well.
Suggest to put it into AOO 3.5.0 release |
Code snippet ----------------------------------------------------------------- case RES_FRAMEDIR: { Any aAny; bOk = rItem.QueryValue( aAny ); if( bOk ) { const XMLPropertyHandler* pWritingModeHandler = XMLPropertyHandlerFactory::CreatePropertyHandler( XML_TYPE_TEXT_WRITING_MODE_WITH_DEFAULT ); OUString sValue; bOk = pWritingModeHandler->exportXML( sValue, aAny, rUnitConverter ); if( bOk ) aOut.append( sValue ); } } break; The object pWritingModeHandler is created in function XMLPropertyHandlerFactory::CreatePropertyHandler on heap. But it will not be released. So it is a memory leak.