Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Fail to load and save document with password | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Writer | Reporter: | Yan Ji <yanji.yj> | ||||||
Component: | save-export | Assignee: | AOO issues mailing list <issues> | ||||||
Status: | CLOSED FIXED | QA Contact: | emiliano.lucetti | ||||||
Severity: | Critical | ||||||||
Priority: | P1 (highest) | CC: | arielch, awf.aoo, cbrand, delest.hagar, hdu, josef.latt, jsc, phoenix.wanglf | ||||||
Version: | 3.4.0 | Keywords: | regression | ||||||
Target Milestone: | 4.0.0 | Flags: | jsc:
3.4.1_release_blocker+
|
||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Created attachment 78745 [details]
Error dialog while loading document with password
Reproducible on Linux x86-64 "hdu" committed SVN revision 1366350 into trunk: #i120385# balance stack in manifest parsing and fix a typoPatch-by: Jian Fang... set release blocker flag "hdu" committed SVN revision 1366353 into branches/AOO34: 120385# balance stack in manifest parsing and fix a typo Fixed now, sorry about that. Thanks to Yan Ji for finding it and for Jian Fang Zhang and Andre Fischer for their suggestions. and for Ariel for confirming it, of course. set flag release blocker flag again *** Issue 120423 has been marked as a duplicate of this issue. *** Verified pass with AOO341 branch r1367911 Reopening because of another regression in the same area. How to reproduce: 1. Create a new text document. 2. Save with password. 3. Close document and load it again. Password is not recognized. "af" committed SVN revision 1369843 into branches/AOO34: #i120385# Fixed reading of encryption specification on 64bit systems. Sorry, wrong status, should be "reopened". This is a 64bit-only bug. A recent change in ManifestImport::startElement modified the reading of manifest properties for digest and encryption type in such a way, that they where internally stored as C++ long values (wrapped in uno Anys). In the UNO API they are defined as IDL long values. IDL long is defined to be always be a signed 32 bit value. For 32bit compilers (at least the ones we use for OpenOffice) the two longs (C++ vs IDL) have the same length. For 64bit compilers C++ long has 64bits. This leads to a problem when the values are later converted back into C++ variables, this time of type sal_Int32. The conversion fails silently and the default values (0 in this case) are used. Zero is neither a valid encryption nor digest type. Therefore validation of the password fails. The fix is simple. Use type sal_Int32 to store the encryption and digest type and everything works as before. Reopened problem can reproduce on Redhat 64bit with AOO341 r1366353. Bug described in comment 11 is not fixed in revision 1369843. I installed en-US and the German langpack. BS: Ubuntu12.04 64bit @jolatt: are you sure that you used the latest builds from Arie? I have just at the moment downloaded and tested that version and can't reproduce it. http://people.apache.org/~arielch/packages/r1369843/linux_x86-64/Apache_OpenOffice_incubating_3.4.1_Linux_x86-64_install-deb_en-US.tar.gz I can create a new document, save with password, close and reopen it again. Everything works as expected. Test env: Linux ubox-jsc 3.0.0-16-generic #28-Ubuntu SMP Fri Jan 27 17:44:39 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux Yes I'm sure, that I have installed the latest build. Because of another reason, I had to restore the home directory of Ubuntu. After this I tried it again and it now works. Sorry. Reopened problem in Comment 11 is verified on Redhat 64bit with Aoo341 r1369843. The fix in Revision 1369843 wasn't applied to trunk *** Issue 122200 has been marked as a duplicate of this issue. *** "arielch" committed SVN revision 1478883 into trunk: i120385 - apply patch from AOO34 branch Fixed on trunk. Adapt Target Milestone, now this has to be verified on 4.0.0. Save and reopen with password verified in AOO 4.0.0 see comment 24 |
Created attachment 78744 [details] Error dialog while saving document with password Build: AOO 3.4.1_r1365887 OS: All Steps: 1. Launch AOO and new Text Document 2. Input some content 3. Save the document with password Defect: An error dialog popup said Error saving the document Untitled 1: General Error. General input/output error. Note if open a document with password a dialog said the document is corrupt. Please refer to the snapshot. This problem doesn't exist in last 3.4.1 build rev 1364591