Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Gradient in metafile is not rotated together with metafile, if anti-aliasing is off. | ||||||
---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | Regina Henschel <rb.henschel> | ||||
Component: | viewing | Assignee: | Armin Le Grand <Armin.Le.Grand> | ||||
Status: | CLOSED FIXED | QA Contact: | |||||
Severity: | Normal | ||||||
Priority: | P3 | CC: | Armin.Le.Grand, binbjguo | ||||
Version: | 4.0.0-dev | ||||||
Target Milestone: | 4.0.0 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Issue Depends on: | |||||||
Issue Blocks: | 121425 | ||||||
Attachments: |
|
Description
Regina Henschel
2012-10-31 12:05:00 UTC
ALG: Taking over ALG: The difference is in VclProcessor2D::RenderPolyPolygonGradientPrimitive2D where for AA always the decomposition is used, for non-AA impDrawGradientToOutDev draws gradients the old way using the whole object range as base for processing. Of course for gradients inside metafiles (where these metafiles are converted to sequelces of primitives as well) to get the rotation applied to the metafile, also the decomposition has to be used. That would mean to add a flag to vclpixelprocessor2d at case PRIMITIVE2D_ID_METAFILEPRIMITIVE2D and use it in VclProcessor2D::RenderPolyPolygonGradientPrimitive2D. It would be simpler to remove the impDrawGradientToOutDev completely and always use the decomposition. It is even possible to remove RenderPolyPolygonGradientPrimitive2D since it's only used in the pixel processor. Also RenderMetafilePrimitive2D is not used anymore and could also be cleaned up since the metafile to primtive convertter is working so well. ALG: Works as expected, done the cleanups described above. Some more checks... "alg" committed SVN revision 1415144 into trunk: #121297# corrected non-AAed gradient rendering when in rotated metafiles, som... ALG: Okay, comitted, done. Verified on Aoo_Trunk_20121203.1303 Rev.1413470, it is fixed. close it added info into wrong bug number, please ignore the comments added by me above. |