Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | shape is lost on import of pptx | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | Regina Henschel <rb.henschel> | ||||||
Component: | open-import | Assignee: | Armin Le Grand <Armin.Le.Grand> | ||||||
Status: | CLOSED FIXED | QA Contact: | |||||||
Severity: | Major | ||||||||
Priority: | P3 | CC: | Armin.Le.Grand | ||||||
Version: | 4.0.0-dev | Keywords: | regression | ||||||
Target Milestone: | 4.0.0 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Issue Depends on: | |||||||||
Issue Blocks: | 121425 | ||||||||
Attachments: |
|
ALG: Looks as if the render command in SdrObjCustomShape::GetSdrObjectFromCustomShape() is not able to produce geometry, needs to be checked. Created attachment 79964 [details]
Proposed solution
ALG: Reason is that the 'Type' setting at the CustomShapeGeometryItem is overwritten in CustomShapeProperties::pushToPropSet when maShapePresetType.getLength() is true. This happens due to creating a completely new PropertySet and setting this as CustomShapeGeometry at the xShape, but without copying the 'type' which was already set from the XEnhancedCustomShapeDefaulter.
Attached is a proposed patch which sets the properties at the existing CustomShapeGeometry PropertySet. I think this is correct, but may someone take a look, please?
"alg" committed SVN revision 1415118 into trunk: #121371# Do set values as planned, but do not override complete CustomShapeGe... ALG: Okay, found a safer solution; now values to be set are added to the sequence of properties and that seq gets set when values were added and not only changed. Kept the other value changers untouched, only adapted those who were set hard (and overwriting) before. |
Created attachment 79927 [details] File with two rectangles and a straight connector between them Open attached document. It contains two rectangles with a straight connector line between them. When you open it, the rectangles are missing. If you use the Navigator, you see, that the rectangles are still there, but you cannot see them. If you save the file to odp-format and unzip it, you can see, that the path of the objects is missing. If you open the file in AOO3.4.1 the shapes are there. [The connector is imported as simple line, but that is another issue.]