|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [sidebar]: Unify usages of ColorPopups and their appearances | ||
|---|---|---|---|
| Product: | General | Reporter: | Armin Le Grand <Armin.Le.Grand> |
| Component: | ui | Assignee: | Armin Le Grand <Armin.Le.Grand> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Normal | ||
| Priority: | P3 | CC: | awf.aoo, issues |
| Version: | 4.0.0-dev | ||
| Target Milestone: | 4.0.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
| Issue Depends on: | |||
| Issue Blocks: | 121420 | ||
|
Description
Armin Le Grand
2013-04-12 08:51:50 UTC
ALG: Grepping... ALG: Detected various users of color-based ValueSets: - svx::sidebar::ColorControl (used in sidebar) - SvxColorDockingWindow (color dock) - SvxColorWindow_Impl (text color popup, maybe more) - More, to be identified Already experimented with auto layouting the first, olling how all this may be unified ALG: As a first step unified used classes, reduced dependencies between svx and sd in their usages. Created a common BaseClass, starting moving implementations there... ALG: Common base class now used for all known popups, looking for the color tabpage table... ALG: Getting the color ValueSets correctly layouted is a tricky thing, still balancing the right codes... ALG: Works pretty well now. Found one more incarnation, in paragraph background tab page, replacing... ALG: To really get this correct I'll have to include all the flag handling for WB_ITEMBORDER/WB_DOUBLEBORDER and the fields WB_NAMEFIELD/WB_NONEFIELD. Looks better, though... ALG: paragraph background tab page replaced, was complicated due to being embedded in even another way to a framing window. Sizing calculatins good now, all color previews use same color item preview size now. Looking for more color dialogs, just in case... ALG: Looking for visualization itself; can this easily be enhanced..? "alg" committed SVN revision 1468340 into trunk: i122041 Unified and centralized control for Color ValueSets ALG: Comitted changes so far, pretty much done. ALG: Another one found: Sheet, Format/sheet/TabColor. Checking... ALG: Adapted some smaller things in other dialogs, centered ColorControl better when used in another framing window. Implemented correct layouting for Calc's own sheet background color dialog (format/sheet/TabColor). Also added test code to make the color control dialog look better. Preparing checkin... ALG: Added vaues for defining behaviour of ColorValueSets to SvtAccessibilityOptions, added defaults, made user-changeable. Preparing commit... "alg" committed SVN revision 1468503 into trunk: i122041 Added vaues for defining behaviour of ColorValueSets to SvtAccessibil... "alg" committed SVN revision 1468510 into trunk: i122041 Adapted the descriptions in Common.xcs slightly "alg" committed SVN revision 1468810 into trunk: i122041 Added WaE patch from Pavel ALG: Removing 'No COlor' entry for LinePropertyPanel line color select; to switch off LineStyle, use LineStyle->None (as in all dialogs, Toolbars and dropdowns). Instead, 'Automatic' is missing in TextPropertyPanel, checking... ALG: Added 'Automatic' to TextPropertyPanel FontColor and HilightColor, added 'No Color' to ParagraphPropertyPanel BackgroundColor, looks good. Checking some more... "alg" committed SVN revision 1468897 into trunk: i122041 Added 'Automatic' to TextPropertyPanel FontColor and HilightColor, ad... ALG: Added slot GetListBoxMaximumLineCount to SvtAccessibilityOptions to have a central, user-definable fallback for the maximum number of lines in DropDown ListBoxes. Preparing using this... ALG: Need to also add some settings to vcl's AllSettings (StyleSettings) to have them available in vcl, doing this... ALG: VclSettings adapted, works well. Chekcing if UserDraws are needed for some svx-defined ListBoxes (HatchingLB, GradientLB, BitmapLB, ColorListBox)... ALG: Not needed, will greatly reduce complexity. Removing... ALG: A ListBox compared to a ValueSet has no color entries at all, thus only the UserDraw mechanism allows showing colors and is used for this. The derivation ColorListBox implements the UserDraw and works around this by keeping an own entry list in parallel to the ListBox one... ALG: Made some experiments with UI element sizes; it shows that these are best defined relative to system UI font size (using MAP_APPFONT like in the ressource files). Checking usage of this for sizes of color dialog box content and ListBox contents, maybe some added option values should be removed again and all stuff be defined relative to UI font size (as the ListBoxes themselves). ALG: MAP_APPFONT works correctly and is the way to go. Adapting to this and taking out some of the already added configuration items again. Looking for a good central place for the default UI-Preview sizes... ALG: Works as expected. Added many details (better Bitmap scaling for FillBitmap preview and similar stuff). Preparing commit... "alg" committed SVN revision 1470611 into trunk: i122041 More unifications for FillStyles, better defaults, better preview vis... ALG: Comitted, done. Preparing update and rebuild of trunk |