Issue 122047

I can not reproduce this.  As discussed on the mailing list, this may be an artifact caused by a broken incremental windows build.

I could reproduced

liuyixuan.527@gmail.com: Please be more specific.

Yes I confirm it could be reproduced in SUSE environment:
In AOO create a writer document and input some text inside;

Select some text and click the superscript or subscript toolbox item, nothing happens;
Correponding boolboxes avaliable in toolbar;
-------------------------
But the exact same build (also confirmed) in windows/Mac working correctly. So it should be a linux platform related issue.

@ zhengfan: do you have a 64 bits system? It seems that 32 bits systems do not show the problem, but both 32 and 64 bits builds show the problem on 64 bits systems.

rgb and/or zhengfan:
Could you please check, if the described defect also occurs in Calc, Impress and Draw. Thx in advance.

(In reply to comment #6)
> rgb and/or zhengfan:
> Could you please check, if the described defect also occurs in Calc, Impress
> and Draw. Thx in advance.

The problem is only present on Writer. On Calc, Impress and Draw both superscript and subscript buttons on sidebar work OK.

Adjusting 'Platform' to 'Linux64' regarding the given comments.

taking over for further investigation

I reproduced the described defect on Linux 32bit (Ubuntu 32bit 11.10)
--> 'Platform' back to 'Linux'

I just figured out in my Linux environments (Ubuntu 11.10 32bit and 64bit) that the sidebar panels whose controls shown/hidden/enabled/disabled depending on the context does not reflect the context dependency. E.g. in the text property panel the highlight color control should be hidden in Calc, Draw and Impress, but under Linux it is not.

Can somebody confirm my observation?

(In reply to comment #11)
> I just figured out in my Linux environments (Ubuntu 11.10 32bit and 64bit)
> that the sidebar panels whose controls shown/hidden/enabled/disabled
> depending on the context does not reflect the context dependency. E.g. in
> the text property panel the highlight color control should be hidden in
> Calc, Draw and Impress, but under Linux it is not.
> 
> Can somebody confirm my observation?

I confirm this on my Linux 64 bits box. Also, when selecting a picture on Writer I can see the rotation controls: rotation of pictures on Writer is not implemented yet so those controls should not be there.

With Olivers preparation and help I have found the root cause for the missing context notifications.  Context notifications are done via the sfx2::sidebar::IContextChangeReceiver interface.  On a context change the SidebarPanelBase class attempts to dynamic_cast the panel object to IContextChangeReceiver.  This cast fails for a few compilers because they provide vtable information only when there is a virtual destructor.  Up to now IContextChangeReceiver had only one abstract virtual function and no destructor.

Adding the virtual destructor should fix this problem.

Added virtual constructors to IContextChangeReceiver for the problem described in this issue and to ILayoutableWindow to fix a problem with disappearing panels.

*** Issue 122052 has been marked as a duplicate of this issue. ***

"af" committed SVN revision 1480980 into trunk:
122047: Adding virutal destructors to interfaces to prevent problems with old...

after SVN revision 1480980, the files 

sfx2/source/sidebar/IContextChangeReceiver.cxx
sfx2/source/sidebar/ILayoutableWindow.cxx

are missing in the trunk. maybe related headers too.

"af" committed SVN revision 1481723 into trunk:
122047: Added missing implementation of virtual destructors.

"orw" committed SVN revision 1481728 into trunk:
122047: adding missing pre-compiled header include

*** Issue 122048 has been marked as a duplicate of this issue. ***