Issue 122151

Summary: Missing Help for "Set Password" dialog
Product: General Reporter: Ariel Constenla-Haile <arielch>
Component: uiAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Normal    
Priority: P3 CC: issues, orcmid
Version: 4.0.0-dev   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---

Description Ariel Constenla-Haile 2013-04-23 22:50:47 UTC
New Writer document
Enter dt and press F3 to insert dummy text
File - Save
Check "Save with password"

Bugs on the "Set Password" dialog:
* no "Help" button, this breaks the guidelines for OpenOffice dialogs
* press F1 while some control of the dialog has the focus: there no Online Help for this dialog
Comment 1 Ariel Constenla-Haile 2013-04-23 22:56:46 UTC
The documentation should specify the password length for the different formats; according to Bug 122107 it seems that ODF has no limit, MSO binary formats have a limit of 15 characters.
Comment 2 orcmid 2013-04-23 23:05:17 UTC
At the time that Save with Password request for the password happens (if this is part of Save As ...), it is known what the format is.  The help can be specific to that.  

It might be wise to truncate the password when saving to .doc, if that will work with Office too.  Otherwise it is probably necessary to reject a password that is too long by refusing to accept more characters.
Comment 3 Ariel Constenla-Haile 2013-05-12 14:26:47 UTC
Setting a break point on the CTRO PasswordToOpenModifyDialog::PasswordToOpenModifyDialog reveals that the max. password length is known when the dialog is created, so that it would be easy to add a string with a place holder for the password length:

* Saving with password to ODF:


Breakpoint 1, PasswordToOpenModifyDialog::PasswordToOpenModifyDialog (this=0x2efbc78, pParent=0x0, nMinPasswdLen=0, nMaxPasswdLen=0, bIsPasswordToModify=true)
    at /build/aoo/src/playground/trunk/main/cui/source/dialogs/passwdomdlg.cxx:300
300         SfxModalDialog( pParent, CUI_RES( RID_DLG_PASSWORD_TO_OPEN_MODIFY ) )


* Saving with password to .doc:


Breakpoint 1, PasswordToOpenModifyDialog::PasswordToOpenModifyDialog (this=0x3803cc8, pParent=0x0, nMinPasswdLen=0, nMaxPasswdLen=15, bIsPasswordToModify=true)
    at /build/aoo/src/playground/trunk/main/cui/source/dialogs/passwdomdlg.cxx:300
300         SfxModalDialog( pParent, CUI_RES( RID_DLG_PASSWORD_TO_OPEN_MODIFY ) )


The fixed text with that string should be displayed only when nMaxPasswdLen > 0