Issue 122317

Summary: Colour palette: missing resource strings
Product: General Reporter: Ariel Constenla-Haile <arielch>
Component: uiAssignee: Armin Le Grand <Armin.Le.Grand>
Status: RESOLVED FIXED QA Contact:
Severity: Normal    
Priority: P3 CC: issues, jsc
Version: 4.0.0-dev   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
sketch of a possible solution none

Description Ariel Constenla-Haile 2013-05-15 07:28:25 UTC
Created attachment 80683 [details]
sketch of a possible solution

The following are some issues with l10n of the colour palette, handled together as they are part of the same fix:

a) The following resource strings are missing after merging Symphony's colour palette:

"Purple", for colours named "Purple [1-10]"
"Sky Blue", for colours named "Sky Blue [1-10]"
"Yellow Green", for colours named "Yellow Green [1-10]"
"Pink", for colours named "Pink [1-10]"
"Turquoise", for colours named "Turquoise [1-10]"

b) RID_SVXSTR_CYAN must be changed to "Cyan" now that there are both "Cyan" and "Turquoise"

c) "Blue nine" should be renamed to "Blue 11" in the colour palette so that the resource string for "Blue" can be reused and there is no need for a new string.

d) The colours that have two words in the name do not follow the current patterns, only the first word in upper-case

"Blue gray"
"Pale yellow"
"Pale green"
"Dark violet"
"Sea blue"

instead:

"Sky Blue [1-10]" ---> should be "Sky blue"
"Yellow Green [1-10]" ---> should be "Yellow green"

e) Could the strings no longer used be removed? For example Sun colours.

The attached patch is an sketch of a possible solution, it also handles the case when the xml file is missing and the colour palette has to be recreated at runtime (bool XColorList::Create()) but this was mainly for other bug (the colour palette looks messed up in colour listboxes).
Comment 1 Ariel Constenla-Haile 2013-05-15 16:45:13 UTC
Fixed by Armin with Revision 1482867

Setting jsc on CC
@jsc: this bug introduces new strings to be translated
Comment 2 SVN Robot 2013-05-16 01:09:57 UTC
"arielch" committed SVN revision 1483139 into trunk:
i122317 - Mark API name as not localizable