Issue 122379

Summary:	[sidebar] regression in cursor navigation of some content panel toolbars closing toolbar rather than moving focus for selection
Product:	General	Reporter:	V Stuart Foote <vstuart.foote>
Component:	ui	Assignee:	AOO issues mailing list <issues>
Status:	CONFIRMED ---	QA Contact:
Severity:	Normal
Priority:	P3	CC:	awf.aoo, fanyuzhen, issues, orw, vstuart.foote
Version:	4.0.0-dev	Keywords:	accessibility
Target Milestone:	---
Hardware:	PC
OS:	Linux, all
Issue Type:	DEFECT	Latest Confirmation in:	---
Developer Difficulty:	---
Issue Depends on:
Issue Blocks:	122257, 122364

Description V Stuart Foote 2013-05-25 08:19:58 UTC

On Linux - Fedora 18 64-bit
AOO400m2(Build:9701)  -  Rev. 1485784
2013-05-24_04:10:24 - Rev. 1485930

When navigating between objects in content panels in the deck - cursor keys are again opening and closing bullet and drop-down selection tool bars. Apparently a regression of fix put in for bug 122270. Possible revision 1485730 work on FocusManager has reintroduced handling problems for some toolbar objects in the content panels. Not affecting all controls as some toolbars seem correct.

With r1485730, Cursors <DOWN>, <RIGHT>,<LEFT>,<UP> now move focus from Deck title <-> Content panel tile <-> Tab bar radio buttons and <TAB> or <ENTER> moving into the panel. And the <ESC> consistently exits a content panel back to its title. That all seems correct.

But when navigating focus with <TAB> between objects in the content panels - the cursor keys are only opening and closing bullet and drop-down selection toolbars--so unable to move focus or to make a button action selection.  

Example Behavior noted in 
Calc - Cell Appearance -> Cell border toolbar & Line Style toolbar

Writer - Text -> Character spacing toolbar
         Paragraph -> Bullets and numbering toolbar
         Paragraph -> Paragraph background color toolbar
         Paragraph -> Line spacing toolbar
         Page -> Orientation, Margin, Size & Column toolbars 

A Windows 7 AOO400m2(Build:9701)  -  Rev. 1485784
of Rev.1485289 -- without r1485730 does not navigate correctly between content panel titles or deck title, but also does not have the open-close action--so calling it a regression for now.

Comment 1 Andre 2013-05-27 13:25:20 UTC

I can reproduce this bug on Ubuntu but no on Windows.  I have to make clean builds on both platforms to find out whether this is a platform related bug or whether my local changes make it better/worse.

Comment 2 V Stuart Foote 2013-05-27 22:39:31 UTC

Tested with pulls of today's Linux and Windows buildbots: 

On Fedora 18 64-bit
AOO400m2(Build:9701)  -  Rev. 1486438
2013-05-27_04:10:03 - Rev. 1486509  (installed 2013-05-27)

the issue of cursor keys opening then closing selection tool bars continues.

=-=-=

On Windows 7 64-bit
AOO400m2(Build:9701)  -  Rev. 1486438
Rev.1486381  (installed 2013-05-27)

issue is not present in Windows which I believe now has r1485730 commit, i.e. <ESC> <TAB> and cursor navigation moves correctly between title bar, content panel and tab bar. 


The bug 122270 definitely affected both Windows and Linux builds, but issue now seems limited to just Linux builds.  Setting hardware to PC - Linux for now.

Comment 3 Andre 2013-05-29 09:07:02 UTC

This bug is basically a general problem of the GTK plugin of VCL.  I can reproduce the bug on Linux and Mac.  Run AOO with another VCL plugin (by setting the environment variable SAL_USE_VCLPLUGIN to "gen") and the bug goes away.

For some reason the focus is not correctly transferred into the floating window of the drop down control.  This works with drop downs in toolbars.  I am currently checking if the special handling of toolbars can be used in sidebar panels.

Comment 4 Andre 2013-05-29 12:47:38 UTC

Focus handling inside floating windows is special, and in the GTK plugin even more special.  In toolbar dropdowns the focus is explicitly set to the new toolbar control.  This approach does not work for sidebar panels because their dropdowns are more complex, ie have more than one control.  They need real focus handling.
There is nothing I can do right now about this.  It is not sidebar specific.  It just becomes more visible with the sidebar.  Fixing this will require more time and a better knowledge of the GTK plugin.  Maybe someone finds the time after the 4.0 release.

Comment 5 Oliver-Rainer Wittmann 2013-06-14 12:23:35 UTC

no show stopper as already been postponed to post 4.0 release as indicated by blocking bug 122364