|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | XHTML export filter extensions | ||
|---|---|---|---|
| Product: | Impress | Reporter: | Habib <hlouafi> |
| Component: | save-export | Assignee: | AOO issues mailing list <issues> |
| Status: | CONFIRMED --- | QA Contact: | |
| Severity: | Major | ||
| Priority: | P3 | CC: | hdu, hlouafi, issues, jsc, MPTrishka, oooforum, pescetti, petko |
| Version: | 3.3.0 or older (OOo) | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Issue Type: | PATCH | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
| Issue Depends on: | |||
| Issue Blocks: | 119663 | ||
| Attachments: | |||
|
Description
Habib
2013-06-07 22:29:27 UTC
Created attachment 80797 [details]
revisions.rar is an archive file that comprises: the patch (modified files) and a unified diff text file.
The atached file is comprised of:
1- a patch folder that contains all the modified files (as a folder structure ready for merge).
2- a unified diff text file containing the content of the modified files.
Created attachment 80798 [details]
A PDF document that sumarizes the achieved improvements.
Created attachment 80870 [details]
A new version of the patch, in which whitespeaces are ignored.
As suggested by Andrea, I uploaded a new version of the patch, in which whitespaces are ignored.
Besides, I state that:
1) These improvements are contributed under the Apache 2 license.
2) As for Sun haders, you are allowd to move them around.
Created attachment 82184 [details]
A version of the patch that can be applied to 4.0.1
The code was reorganized in different folders and files since the version Habib wrote his patch for, and it had also undergone several internal changes, so the patch failed to apply in multiple spots.
I'm attaching a reworked version of the patch that applies to OpenOffice 4.0.1 or the current trunk.
Remarks:
1) The patch has not been tested at all, and it should be, since the underlying code changed.
2) The relative path to wz_jsgraphics.js may have changed and may have to be fixed.
3) Comments, whitespace changes and attribution to Habib have been ignored in this patch (Habib, of course you will receive proper credit, but we will do as for all other contributors; we don't write names in the source code, to keep it clean).
4) The <xsl:template match="draw:frame"> section (line 918 of the patched odf2xhtml/export/common/body.xsl) changed substantially and should be reviewed to check that the patch is still doing what it was meant for.
5) A couple of AL2 headers appear to have changed, but this is just due to inconsistent newline handling; they are untouched and this part of the patch can be ignored.
6) The patch is not yet ready to be committed; for example, it includes an external JavaScript library that must still be sorted. I'm providing it so that integration can continue.
Next step will be to divide Habib's work in separate patches to make it more manageable.
Any news about this commit? If I recall correctly (this goes back a few years), the main issue here was that we depended on an unclearly licensed JavaScript library and investigations about the possibility to include it were inconclusive. This was made more complex, again if I recall correctly, by the fact that the author was unreachable. The library was used only for a part of the patch, so theoretically one could factor out that part and proceed with the rest. It is unclear to me what the goal of the patch is. Peter: if you don't understand what this issue is about, just see the list of attachments; the one named "A PDF document that summarizes the achieved improvements" is a very detailed description. But we can use the dev list for talks and focus on the technical stuff here in Bugzilla. |