Issue 122889

Created attachment 81200 [details]
Calc file

Confirmed with 2.4.3 and Rev. 1507307 on Win 7.

confirming

Some further investigation reveals the following:
- The background color of the larger rectangle is imported as 'Blue 9' in AOO 4.0.0 while in AOO 3.4.1 it is 'Blue 8'. Changing the background color corrects the document.

So, do I need to correct this in my document or it would be corrected in next relese, 4.1?

ALG: Taking a look...

ALG: This already happens in AOO341, e.g:
- open doc
- ungroup the two rects (to get at the one without gradient which uses blue8)
- copy/paste, D&D to a fresh calc, writer or draw/impress -> it gets blue9 as fill color

I have no idea why this happens, but it seems to be more a problem with the document.

Also interesting (still in 3.4.1):
- New calc
- Add one rect in blue9 (default, change nothing)
- D&D or Copy/paste to any new doc in 3.4.1 -> works
- D&D or Copy/paste to opened example doc -> color changes to blue8 (?)

Doing the same in AOO400 all works as expected, also last case.

Looking why at load time (to AOO400) color changes...

ALG: Tried to create a reduced example in AOO341, loading with AOO400:
- with two rects, one untouched (blue9), one changed to blue8
-> works
- same, but objects grouped
-> works

@sevalav: With which office version did you produce that file?

Created attachment 81434 [details]
Reduced example derived from original

ALG: Have created a reduced example from original, adding here. It only has the single rectangle left which changes color, so I will take it for further inspection. This already shows that it has noting to do with grouping.

ALG: The problem indeed comes from the FillStyle for the object *not* having a fill color set (and no fill style, thus defaulting to "solid". This cannot be reproduced with creating a new file with a new rectangle shape, neither starting from AOO341 nor from AOO400.
The style from the text file is:

<style:graphic-properties draw:stroke="none" svg:stroke-color="#99ccff" draw:opacity-name="" draw:textarea-horizontal-align="center" draw:textarea-vertical-align="middle"/>

while from a new file you get:

<style:graphic-properties draw:stroke="none" draw:fill="solid" draw:fill-color="#99ccff" draw:textarea-horizontal-align="center" draw:textarea-vertical-align="middle"/>

Thus, the default fill color is used (blue9 or now 'blue calssic'). The question is where AOO341 takes the fill color from; also there the default is 'blue9', not 'blue8'.

ALG: When trying to repoduce in AOO341 with loading in AOO400:

version (1): D&D or copy/paste the two rects from draw/impress: ALl attributes get hard set at the objects, at export both have FillStyle and FillColor set as hard attributes

version (2): Creating both in new calc in 341: the one with 'blue8' has fill and color set, the one with 'blue9' has no fill or color set. It still works since in the ODF in the styles.xml in style:graphic-properties the defaults are defined and there draw:fill-color="#cfe7f5" is set what is 'blue9'.

The example does not work since there is only a draw:fill-color for the object with 'blue9' (so this stays at load time), but not for the object with 'blue8' *and* there is no default draw:fill-color given in the styles.xml style:graphic-properties, thus the default (blue9) is used.
In AOO341 still 'blue8' was used as default due to an error in calc not setting the correct defaults for the pool, even when the defaults for filling were already set correctly. Without that error the behavior of this file would have already shown in AOO341, too.
This gives a slight correction possibility at load time: If there is no color set and there is no default color, fallback to using the old AOO341 pool default of 'blue8'. But since only files which cannot regularly be created (AFAIK) show this and this correction is not easy, I am not sure if this should be done.

This explains why the example file changes fill color from 'blue8' to 'blue9'. It also raises the question how that file was created, there is no way to create this in AOO341/340 nor AOO400. Only sevalav can shine more light on this.

(In reply to Armin Le Grand from comment #8)

> @sevalav: With which office version did you produce that file?

Uh... I am not 100%  sure, but the first version have invoices with date 01.01.2011. But with this file I tested my code. So, it is possible that I just "stolen" old invoices and put in that file for testing. Maybe I created this file with OOo3.3.

ALG: @sevalav: Okay, thanks for cheking and trying to find out! If this is not reproducible with other files (at best with a way to create this files), please change your file and think about removing the regression keyword. Thanks!