Issue 123359

Summary:	Table in Title, Content layout causing crash
Product:	Impress	Reporter:	Edwin Sharp <elish>
Component:	editing	Assignee:	Armin Le Grand <Armin.Le.Grand>
Status:	CLOSED FIXED	QA Contact:	Michael Rutherford <mbr>
Severity:	Normal
Priority:	P3	CC:	Armin.Le.Grand, fanyuzhen, issues, orw, pescetti
Version:	4.0.0	Keywords:	crash, regression
Target Milestone:	4.1.0
Hardware:	All
OS:	All
Issue Type:	DEFECT	Latest Confirmation in:	4.0.1
Developer Difficulty:	---

Description Edwin Sharp 2013-09-25 13:16:55 UTC

1. File - New - Presentation
2. Switch to Title, Content layout
3. Click on Click to add text
4. Insert - Table... - OK

Crash.

AOO410m1(Build:9750)  -  Rev. 1525015
2013-09-24_04:09:45 - Rev. 1525769 

4.0.1 RC3 testing

Comment 1 Edwin Sharp 2013-09-25 17:34:36 UTC

Updating fields.

Comment 2 Edwin Sharp 2013-09-26 19:39:11 UTC

Crash with failed recovery in:

AOO401m5(Build:9714)  -  Rev. 1524958
2013-09-20 11:54 - Linux x86_64

Comment 3 Edwin Sharp 2013-09-28 17:59:08 UTC

Same as comment 2 on another PC.

Rev. 1524958 Debian

Comment 4 Andrea Pescetti 2013-09-29 16:51:27 UTC

Confirming with AOO401m5 on Linux 64 bit RPM. Note: one must follow the exact steps as reported by Edwin, or I don't get the crash (namely, clicking on the icon rather than on "Insert text" works).

The same problem happens in 4.0.0, but not in 3.4.1.

If detected earlier, this would have been a good candidate showstopper for 4.0.1. Setting the target to 4.1.0.

[Note: I can't add "Last confirmed on: 4.0.1" since that version is not listed yet]

Comment 5 Oliver-Rainer Wittmann 2013-10-07 13:18:11 UTC

I am not able to reproduce the described crash on Windows 7 64bit with AOO 4.0.0 and AOO 4.0.1 and on Ubuntu 11.10 64bit with AOO 4.0.1

Andrea mentioned that 'one must follow the exact steps...'.
@Andrea: What do you mean by '... (namely, clicking on the icon rather than on "Insert text" works)'?

When I followed the given steps the cursor is blinking in the slide content text frame before I am inserting the table via menu Insert - Table - Ok

Comment 6 Oliver-Rainer Wittmann 2013-10-07 13:21:00 UTC

(In reply to Oliver-Rainer Wittmann from comment #5)
> I am not able to reproduce the described crash on Windows 7 64bit with AOO
> 4.0.0 and AOO 4.0.1 and on Ubuntu 11.10 64bit with AOO 4.0.1
> 
> Andrea mentioned that 'one must follow the exact steps...'.
> @Andrea: What do you mean by '... (namely, clicking on the icon rather than
> on "Insert text" works)'?
> 
> When I followed the given steps the cursor is blinking in the slide content
> text frame before I am inserting the table via menu Insert - Table - Ok

I got it - sorry for the noise.

Comment 7 Oliver-Rainer Wittmann 2013-10-07 13:25:36 UTC

Now, I reproduced the described crash on Windows 7 64bit and Ubuntu 11.10 64bit with AOO 4.0.1
--> platform = All

Comment 8 Armin Le Grand 2013-10-09 15:15:23 UTC

ALG: Looks as if a SdrEndTextEdit call is missing when the table is inserted; the object which gets replaced is in edit mode; that edit mode is left when model changes (on callback) and there the crash seems to be originated. Comparing with insert graphic...

Comment 9 Armin Le Grand 2013-10-09 15:27:01 UTC

ALG: Grep and flags back

Comment 10 SVN Robot 2013-10-09 15:31:39 UTC

"alg" committed SVN revision 1530680 into trunk:
i123359 need to call SdrEndTextEdit before manipulating objects at model/view

Comment 11 Armin Le Grand 2013-10-10 09:33:21 UTC

ALG: Comitted, done.

Comment 12 Oliver-Rainer Wittmann 2014-04-02 11:24:21 UTC

Verified on Ubuntu 10.04 (64bit) with build from branch AOO410 (rev. 1583666)

Verified on Windows 7 with local build of branch AOO410, rev. 1582710 and with buildbot build, rev. 1582709