Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Shapes only accept new area properties after rotation, Format Toolbar and Shape color mismatch | ||
---|---|---|---|
Product: | Draw | Reporter: | Rainer Bielefeld <rainerbielefeld_ooo_qa> |
Component: | editing | Assignee: | Armin Le Grand <Armin.Le.Grand> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | Critical | ||
Priority: | P3 | CC: | Armin.Le.Grand, doneyourself, issues, rainerbielefeld_ooo_qa, rb.henschel |
Version: | 4.1.0-dev | Keywords: | regression |
Target Milestone: | 4.1.0 | ||
Hardware: | All | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
Rainer Bielefeld
2013-10-29 05:25:09 UTC
Seems that this one is a much more simple DRAW "Basic Shape" problem: With 4.1-dev redo test from original report, but not with sample document, but with a blank new Drawing created from AOO Start Center Button with a new Basic Shape "Diamond" drawn by you. All effects from original report (a), (b) and color change only after rotation will be reproducible. (d) Already Reproducible with server installation of "AOO 4.1.0-Dev – English UI / German locale - [AOO410m1(Build:9750) - Rev. 1525917 - 2013-09-25]" on German WIN7 Home Premium (64bit)", own separate user profile. (e) was still ok with server installation of "AOO 4.1.0-Dev – English UI / German locale - [AOO410m1(Build:9750) - Rev. 1523968 - 2013-09-18]" on German WIN7 Home Premium (64bit)", own separate user profile. Also affected: Symbol Shapes, Block Arrows, Flowcharts, Callouts, Stars. This bug makes Draw more or less unusable, so Critical. Only custom shapes are affected. The error is not only with area, but with line and extrusion on/off too. The shape gets the new property, but it is drawn only after the path of the shape changes for example by handle, or rotation, or resizing. The new property is saved and is visible after reload. It is not a simple screen refreshing problem, move or hide/show the shape doesn't help. undo/ redo makes the new property value visible. ALG: Works in AOO401, but indeed broken in trunk. Need to check what may have changed here... ALG: Unifying changes to CustomShapes in the CustomShapeProperties implementation using UpdateTextFrameStatus was too strict; InvalidateRenderGeometry does not only need to be called when TextFrameStatus changes, but in all places where it was called before and when TextFrameStatus changes. Adapted this, checking... ALG: Works as expected, comitting, done. Thanks for finding this; it would have really been bad and shows that looking at dev versions is a necessity! "alg" committed SVN revision 1537454 into trunk: i123573 corrected reaction on ItemChanges for CustomShapes Verify on AOO410m1(Build:9750) - Rev. 1570848 Rev.1570848 on windows7 ,Pass |