Issue 124555

Please describe in detail, what do you do and what does not work. I do not understand "Testlink test 427".

1. File - New - Presentation
2. View - Toolbars - Drawing
3. Click on Symbol Shapes selection arrow - select Smiley Face - draw on slide - no problem
4. Click on Symbol Shapes selection arrow - select Puzzle - draw on slide - nothing is drawn

Created attachment 83032 [details]
Impress screenshot

There should be a puzzle next to smiley face

Hi Edwin, no problem here. I can draw all mentioned shapes. AOO410m14(Build:9760)  -  Rev. 1573601 2014-03-03 17:47:48 (Mo, 03 Mrz 2014)
Windows 7, AOO with German local but English UI.

Are you using the AOO4.1 beta, or a daily build from trunk? If it is a daily build, please include the revision number.

I have found "Testlink test 427" in the meantime. It has nothing to do with your problem, but is about creating an animated bitmap.

(In reply to Regina Henschel from comment #4)
> Hi Edwin, no problem here. I can draw all mentioned shapes.
> AOO410m14(Build:9760)  -  Rev. 1573601 2014-03-03 17:47:48 (Mo, 03 Mrz 2014)
> Windows 7, AOO with German local but English UI.
> 
> Are you using the AOO4.1 beta, or a daily build from trunk? If it is a daily
> build, please include the revision number.
Rev. 1582709
> I have found "Testlink test 427" in the meantime. It has nothing to do with
> your problem, but is about creating an animated bitmap.
"New a SD and Input some objects, such as shape, picture" - step 2 in test 427.

Reproducible with server installation of "AOO 4.1.0-dev – English UI / German locale - [AOO410m14(Build:9760)  -  Rev. 1582709 2014-03-30]" on German WIN7 Home Premium (64bit)", own separate user profile.

Additional Info:
(a) seems to be a very new regression after Regina's Rev. 1573601
(b) Existing presentations: affected symbol shapes are visible with 
    Rev. 1582709 2014-03-30
(b1) Adding such a symbol in presentation from (b) will fail, is invisible. 
(c) it seems that contents of the symbol shapes is missing in latest version(s),
    so that it might be an installation issue?

The shape has a wrong draw:enhanced-geometry. The error happens, when generating a new shape. If a document contains such shape and is reopened, then the shape is correct. The error happens too, when inserting a default shape by accessibility methods (F6 and Ctrl-Enter).

such shape -> a correct shape

Tried with Trunk version AOO410m14(Build:9760)  -  Rev. 1578923, no problem. Tried with AOO4.1.0 beta (AOO410m14(Build:9760)  -  Rev. 1572596), also no problem. Looks as if I need a new most recent trunk version...

I could not reproduce the described defect in AOO 4.1.0 Beta.
I can reproduce the described defect in recent build bot installation set (rev. 1582709) and in my own recent build from branch AOO410.
--> I think this issue is relevant for the 4.1.0 release

Reverting revision 1582689 fixes also this problem.

Oliver has found the root cause: a wrong Seek in ImplReadDIBFileHeader (vcl/source/gdi/dibtools.cxx).

working together with Andre on a solution

Created attachment 83043 [details]
patch to solve the defect

restore stream position after Seek to the end of stream

Requesting show-stopper-status
- The root cause of this defect has been found and a fix is available.
- The fix will also fix issue 124558, issue 124559 and issue 124562
- All issues are regression introduced lately on our release code line for 4.1.0

grant showstopper flag

Some more information about the root cause:  a Seek() to stream end (the usual technique to determine the stream length) did not restore the previous stream position.  Subsequent reads from the stream read data from the wrong position.

"orw" committed SVN revision 1583336 into trunk:
124555: restore stream position after Seek to end of stream

"orw" committed SVN revision 1583342 into branches/AOO410:
124555: restore stream position after Seek to end of stream

fixed on trunk and on branch AOO410 for the next release

verified with
AOO410m18(Build:9764)  -  Rev. 1589052
2014-04-22 12:11 - Linux x86_64
Debian