Issue 124856

Summary: doAccessibleAction(0) failed on combobox with dropdown
Product: App Dev Reporter: hanya <hanya.runo>
Component: apiAssignee: AOO issues mailing list <issues>
Status: CLOSED FIXED QA Contact:
Severity: Normal    
Priority: P3 CC: jsc, kschenk, pescetti, rekhask, stevanovicvladislav, steve.yin.aoo
Version: 4.1.0Keywords: regression
Target Milestone: 4.1.1Flags: jsc: 4.1.1_release_blocker+
Hardware: All   
OS: All   
URL: https://forum.openoffice.org/en/forum/viewtopic.php?f=20&t=69630
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 121767    
Attachments:
Description Flags
Test document contains macro
none
Proposed patch to change number of accessible actions for dropdown enabled none

Description hanya 2014-05-08 15:36:01 UTC 
Created attachment 83362 [details]
Test document contains macro

Reported in: https://forum.openoffice.org/en/forum/viewtopic.php?f=20&t=69630

Open the attached document and click "Execute macro" field to open the dialog. 
There are two combobox, one is dropdown enabled (ComboBox1) and another is diabled placed below (ComboBox2).
- Push "Info" button on the dialog
-> opened messagebox shows number of count of actions. ComboBox1 should have 1 action and another should not have any actions.
- Push "Action 0 for box1" button on the dialog.
-> It tries to execute doAccessibleAction method with action index 0. But it shows com.sun.star.lang.IndexOutOfBoundsException on AOO 4.1.0.

It worked on 4.0.1.

VCLXAccessibleBox::getAccessibleActionCount method returns 0 for m_bIsDropDownBox is true and 0 for false. 
But it should be 1 for true, 0 for otherwise.
Comment 1 hanya 2014-05-09 15:45:38 UTC 
Add regression keyword.
Comment 2 hanya 2014-05-14 17:11:46 UTC 
Created attachment 83386 [details]
Proposed patch to change number of accessible actions for dropdown enabled

The patch contains to change count of accessible action for dropdown enabled box. 
I found the problem in getAccessibleActionDescription method and it related to 
this subject.

I met another problem after the above fix. When I choose an entry from the dropdown box 
shown by the accessible action, the office crashed. 
Because m_xText instance variable is already non-valid reference after the dropdown 
is closed that shown by the accessible action in 
case VCLEVENT_COMBOBOX_SELECT of VCLXAccessibleBox::ProcessWindowEvent method.
After the attached patch, the crash is not happen. But the later part of the 
VCLEVENT_COMBOBOX_SELECT is never happen, it seems.
Comment 3 jsc 2014-07-01 15:19:47 UTC 
it's a regression and a patch is in place
Comment 4 SVN Robot 2014-07-02 08:19:38 UTC 
"jsc" committed SVN revision 1607279 into trunk:
#124856# correct return number of accessible actions for dropdown box
Comment 5 SVN Robot 2014-07-02 08:26:41 UTC 
"jsc" committed SVN revision 1607286 into branches/AOO410:
#124856# merge fix frrom trunk, correct number of accessible actions for drop...
Comment 6 jsc 2014-07-02 08:29:00 UTC 
patch reviewed and integrated on trunk and AOO410 branch
Comment 7 Wlada 2014-07-02 13:09:34 UTC 
Is this patch integrated in AOO411m1(Build:9770)  -  Rev. 1603804
2014-06-16 14:10:45 (Mo, 16 Jun 2014)?
Comment 8 jsc 2014-07-02 15:38:12 UTC 
no it will be integrated in the next milestone, you can see the svn commit messages from today ;-)
Comment 9 jsc 2014-07-07 08:51:20 UTC 
set target
Comment 10 jsc 2014-07-10 15:41:11 UTC 
grant show stopper flag
Comment 11 Kay 2014-07-15 20:11:46 UTC 
Verified fixed with milestone 2--

AOO411m2(Build:9771)  -  Rev. 1608452
2014-07-07 15:22 - Linux i686
Comment 12 Rekha S 2014-07-25 21:03:25 UTC 
Verified fixed on Windows 8 on AOO 4.1.1 m3 , Rev: 1611634

Now the Macros are running without any exceptions


thanks
Rekha