Issue 125235

Summary: Export to PDF defaults to last used directory
Product: General Reporter: niekd <niek>
Component: uiAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Normal    
Priority: P3 CC: Armin.Le.Grand, mistertimisterti, oliver.brinzing
Version: 3.3.0 or older (OOo)   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Issue Type: DEFECT Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---
Attachments:
Description Flags
xfilepicker none

Description niekd 2014-07-10 12:13:06 UTC
Ref:Issue 13311,  Issue 62906
	

We have been using OOo and AOO for 7 years to create invoices in Writer and export them to PDF in the present directory. The PDF always has been saved to the current working directory (of the document we are working on). Since AOO 4.1.0 however, the PDF is saved to the last used directory. This leads to PDF files ending up in wrong places. Additional steps required now to select the present working directory. We are not happy with this change that was uncalled for and want the original behavior restored. OR, we want a program preference, General, Default export directory: Use current / Use last used.

How to repeat: 

Create directory A
Create Writer document in dir. A
Use button Export to PDF - if this is the first time, dir A will be selected, otherwise the last used location will be selected.
Create directory B
Create Writer document in dir. B
Use button Export to PDF - dir A will be selected as save to location.
Comment 1 Armin Le Grand 2014-07-10 15:02:29 UTC
Checked and indeed is different in AOO410/411 as described. May be related to issue 110619 or issue  123544. In AOO401 it behaves the same.

@niekd: Could you please add information in which version it worked as you were used to/as you described?
@Ariel: Any guesses (due to experience with 123544) ?
Comment 2 Oliver Brinzing 2014-07-10 17:53:37 UTC
.
Comment 3 Oliver Brinzing 2014-07-10 18:23:12 UTC
Created attachment 83679 [details]
xfilepicker

i can confirm the problem with win7.
if there is a last used directory it is preselected in xfilepicker.
the directory set with "displaydirectoy" is shown in "Anwendungslinks".
please have a look at the attachment.
Comment 4 Oliver Brinzing 2014-07-10 18:29:12 UTC
btw: i cannot confirm the problem with win xp.
Comment 5 Oliver Brinzing 2014-07-10 18:36:53 UTC
maybe also related to:

target directory defaults to "Gallery" instead of "My Documents"
https://issues.apache.org/ooo/show_bug.cgi?id=108835

if i try to export an unsaved document, "gallery" is shown in "Anwendungslinks"
Comment 6 niekd 2014-07-11 11:52:42 UTC
(In reply to Armin Le Grand from comment #1)
> Checked and indeed is different in AOO410/411 as described. May be related
> to issue 110619 or issue  123544. In AOO401 it behaves the same.
> 
> @niekd: Could you please add information in which version it worked as you
> were used to/as you described?
> @Ariel: Any guesses (due to experience with 123544) ?

That would have been the preceding version 4.0.1 as we don't install betas.
Comment 7 Ariel Constenla-Haile 2014-07-11 15:15:21 UTC
IIRC the issue is in

void SAL_CALL VistaFilePicker::setDisplayDirectory(const ::rtl::OUString& sDirectory)
fpicker/source/win32/filepicker/VistaFilePicker.cxx

void VistaFilePickerImpl::impl_sta_SetDirectory(const RequestRef& rRequest)
fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx

The later ends up calling SetDefaultFolder instead of SetFolder
For the difference, see
http://msdn.microsoft.com/en-us/library/windows/desktop/bb761828%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/bb775972%28v=vs.85%29.aspx

SetFolder is called only:

- if the dialog is currently being executed (that's usually never the case, as the dialog is instantiated, initialized, set up, and then executed)

- if a special flag is set to force setting the folder. But this flag is set only under the special case when the configuration key org.openoffice.Office.Common/Path/Info/WorkPathChanged is true (and in this case, the key is set immediately to false)

--------------------

AFAIK this isn't a regression, it has being working like that since the beginning.
Comment 8 Ariel Constenla-Haile 2014-07-11 15:16:46 UTC
(In reply to brinzing from comment #4)
> btw: i cannot confirm the problem with win xp.

There are two FilePicker implementations in Windows. The VistaFilePicker is the one that's buggy.
Comment 9 Armin Le Grand 2014-07-14 16:19:13 UTC
@Ariel: Does comment 8 mean that
- this only happens on Vista?
- with AOO local dialogs it can be avoided?
- that when it's no regression it happens all the time under special conditions?
Comment 10 Ariel Constenla-Haile 2014-07-19 17:38:29 UTC
(In reply to Armin Le Grand from comment #9)
> @Ariel: Does comment 8 mean that
> - this only happens on Vista?

on Windows >= Vista

> - with AOO local dialogs it can be avoided?

yes, as they are different implementations.

> - that when it's no regression it happens all the time under special
> conditions?

The only time when the dialog does not default to the last used directory is when you use it for the first time (for example, start OpenOffice, create a new Writer document, type some dummy text, export the document to PDF without saving in; you'll be facing bug 108835)
Comment 11 Armin Le Grand 2014-07-21 09:53:30 UTC
Thanks Ariel.
@niekd: Looks as if nothing was changed. Maybe you have used the AOO own dialogs in your previous usage? Please check tools/options/OpenOffice/general/use OpenOffice dialogs.
Comment 12 niekd 2014-08-05 12:18:21 UTC
Thanks for clarifying the different dialogs behavior of AOO in Windows 7 and Windows XP. As a matter of coincidence, we upgraded from AOO 4.0.1 to AOO 4.1.0 at the same time we upgraded from Windows XP to Windows 7. This could explain why we encountered the issue at that time and assumed the difference was in OpenOffice.

To verify, we installed AOO 4.1.0 on an older computer running Windows XP and repeated the test. Indeed it was found that AOO 4.1.0 on Windows XP does NOT 'remember' the last used directory for PDF export.

While the issue is not, as we assumed, a difference between versions 4.0.1 and 4.1.0, we still think it is desirable that the behavior is consistent between operating system versions, and we prefer the program NOT to 'remember' the last export directory. However, we tried using OpenOffice dialogs (4.1.0 on Windows 7) and this seems to mitigate the issue. Thanks to all who responded.
Comment 13 Ariel Constenla-Haile 2015-01-15 00:26:05 UTC
Not a regression, but a bug (or feature?) in the Vista FilePicker implemetation.
Comment 14 Ariel Constenla-Haile 2015-01-15 17:15:39 UTC
*** Issue 126038 has been marked as a duplicate of this issue. ***