Issue 125699

Summary: No automatic font color adaption to paragraphbackground or page background color
Product: Writer Reporter: Rainer Bielefeld <rainerbielefeld_ooo_qa>
Component: viewingAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Normal    
Priority: P3 CC: andra.bacanu, Armin.Le.Grand, damjan, mseidel, rainerbielefeld_ooo_qa
Version: 4.2.0-devKeywords: regression
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---
Attachments:
Description Flags
Sample Document with screenshot
none
Scrrenshots with my findings none

Description Rainer Bielefeld 2014-10-01 04:39:51 UTC
Color of characters should switch from black to white for dark paragraph background colors like blue or black.
Works fine for dark character background color
Still worked fine with AOO 4.1.1

Steps how to reproduce:
1. With AOO 4.2-dev open blank new Writer document
2. add some paragraps with text as 1 … 5 in Test area
3. Apply paragraph background color with menu Format  > Paragraph > Area (tab) > Fill = Blue
Expected: Character color switches to “black”
Actual: no font color adaption
Comment 1 Rainer Bielefeld 2014-10-01 04:40:26 UTC
Created attachment 84003 [details]
Sample Document with screenshot
Comment 2 Rainer Bielefeld 2014-10-01 05:43:48 UTC
For black page background automatic character color should change from black to white, what also does not work with 4.2-dev
Comment 3 andra 2015-01-14 20:14:56 UTC
I tried to replicate the bug on the following configuration: Windows 7, 32 bit Operating System.

I tried to follow the exact steps as described in the initial bug report on both Ooo 4.1.1 and 4.2-dev with the specification that the “Area” tab from Format->Paragraph is not present in Ooo 4.1.1, but I used the icon from the right side of the screen to change the background color.

I could not reproduce the bug on Ooo 4.1.1, but this bug could be easily reproducible on Ooo 4.2- dev version.  

Here are my findings after trying to do more investigations over this bug: 

a)-in Ooo 4.1.1 the font color is automatically changed from black to white ONLY if the font color is set to “automatic”. Based on this, I followed the below steps in my attempt to reproduce the defect on Ooo 4.2-dev: 

1.Create a new text document (File->New->Text document)
2.Set the font color to automatic (Tools->Options->OpenOffice->Appearance)
3.Write a text and select it all 
4.Change the color of the background to a dark color (Format->Paragraph>Area tab)(e.g. black or dark blue)

 Actual result: The font color is black. It is not automatically converted to white after step 4.

b)-I believe that the quantity of the colors Red, Green and Blue from which the background color is composed has an influence on the automatically conversion of the font color from black to white. I followed the next steps on both Ooo 4.1.1 and Ooo 4.2-dev: 

1. Create a new text document (File->New->Text document)
2. Set the font color to automatic (Tools->Options->OpenOffice->Appearance)
3.Create a new color with a certain amount of Red, Green and Blue (e.g. R= 100, G=0, B=0)(Tools->Options->Colors->Write the desired values for R,G,B->click on Add button->Add a title for the color)
4.Repeat step 3 with other values (e.g. R=0, G=100, B=0) )(Tools->Options->Colors->Write the desired values for R,G,B->click on Add button->Add a title for the color)
5. Repeat step 3 with other values (e.g. R=0, G=0, B=100) )(Tools->Options->Colors->Write the desired values for R,G,B->click on Add button->Add a title for the color)
6.Write a text and select it 
7. Change the color of the background (select the color created in step 3)
8. Change the color of the background (select the color created in step 4)
9. Change the color of the background (select the color created in step 5)

Actual result:

-in Ooo 4.1.1 : after step 7 the font color automatically converts to white. After step 8 the font color is not converted to white (it remaines black). After step 9 the font color automatically converts to white. 

-in Ooo 4.2-dev: after all steps 7,8,9 the font color remains black.
Comment 4 andra 2015-01-14 20:20:03 UTC
Created attachment 84421 [details]
Scrrenshots with my findings

Please see the screenshots from the attached document. The screesnhots are related to my findings.
Comment 5 Rainer Bielefeld 2015-01-18 07:36:56 UTC
Still reproducible with German AOO420m1(Build:9800)  -  Rev. 1651021 on WIN7 64Bit with sample document and newly created writer document.
Comment 6 Ariel Constenla-Haile 2015-01-18 14:42:30 UTC
Confirmed on current trunk
Comment 7 damjan 2023-12-08 05:38:28 UTC
Fortunately by now I have a large number of precompiled trunk versions from different dates, that can be tested easily:

4.1.13 - works
latest trunk - regression
6dd50e53129adaa307ec5b2aba73acd299ab2e3b (2014-10-21) - regression
f331e23ffae9e26f93997dc8f02086c5733e80df (2014-02-25) - works

So the regression happened within the trunk branch some time during 2014, between February and October.

$ git rev-list f331e23ffae9e26f93997dc8f02086c5733e80df..6dd50e53129adaa307ec5b2aba73acd299ab2e3b |wc -l
     385

385 possible commits!

$ git rev-list f331e23ffae9e26f93997dc8f02086c5733e80df..6dd50e53129adaa307ec5b2aba73acd299ab2e3b sw |wc -l
     66

66 commits to "StarWriter".

There were many changes that could have caused this.

A git bisect may be the only way to narrow this down further.
Comment 8 damjan 2023-12-29 17:18:40 UTC
After days of "git bisect", I finally found the regression:

---snip---
56b35d86153c02ff07ff2435fcc383d035fd8df0 is the first bad commit
commit 56b35d86153c02ff07ff2435fcc383d035fd8df0
Author: Armin Le Grand <alg@apache.org>
Date:   Mon Jun 2 15:00:50 2014 +0000

    i124638 Second step of DrawingLayer FillAttributes for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes
    
    git-svn-id: https://svn.apache.org/repos/asf/openoffice/trunk@1599233 13f79535-47bb-0310-9956-ffa450edef68
---snip---



Unfortunately it's an ENORMOUS set of changes:
 110 files changed, 6839 insertions(+), 4113 deletions(-)


Adding author to CC.

Armin: any ideas?