Issue 127165

Summary: Clicking "No" in Java dialog causes abnormal exit on FreeBSD
Product: App Dev Reporter: damjan
Component: scriptingAssignee: AOO issues mailing list <issues>
Status: CLOSED FIXED QA Contact:
Severity: Major    
Priority: P5 (lowest) CC: mseidel, rbircher
Version: 4.2.0-devKeywords: crash, release_blocker
Target Milestone: 4.1.4Flags: arielch: 4.1.4_release_blocker+
Hardware: All   
OS: FreeBSD   
See Also: https://bz.apache.org/ooo/show_bug.cgi?id=125868
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---

Description damjan 2016-10-16 16:30:18 UTC
On FreeBSD 10.3, with the latest AOO trunk built with Clang like the rest of the system, disabling Java, restarting AOO, creating a Writer document, inserting a picture, right-clicking the picture and choosing "Picture.." from the menu, then going to the "Macro" tab, causes the "Enable JRE" dialog to come up.

Clicking "No" in this dialog causes AOO to immediately exit and bring up the recovery dialog.
Comment 1 SVN Robot 2016-10-16 16:32:10 UTC
"damjan" committed SVN revision 1765170 into trunk:
#i127165# Clicking "No" in Java dialog causes abnormal exit on FreeBSD
Comment 2 damjan 2016-10-16 16:33:59 UTC
Patch committed, resolving fixed. The code should have caused the problem on all operating systems, but for whatever reason the crash only seemed to happen on FreeBSD.
Comment 3 Matthias Seidel 2016-10-19 12:40:04 UTC
(In reply to damjan from comment #0)
> On FreeBSD 10.3, with the latest AOO trunk built with Clang like the rest of
> the system, disabling Java, restarting AOO, creating a Writer document,
> inserting a picture, right-clicking the picture and choosing "Picture.."
> from the menu, then going to the "Macro" tab, causes the "Enable JRE" dialog
> to come up.
> 
> Clicking "No" in this dialog causes AOO to immediately exit and bring up the
> recovery dialog.

On Windows (and Ubuntu) there is a loop at that point. I have to click 5-6 times NO to get out of it.
I will test an actual 4.20dev to see if your commit changes that behaviour.

If yes this should go into 4.1.4.
Comment 4 Matthias Seidel 2016-10-19 15:42:00 UTC
Actually it needs 10-15 clicks to close the dialog on Windows (and Ubuntu).

A "normal" user would think the program hangs and would shut it down via taskmanager...
Comment 5 Matthias Seidel 2016-10-22 11:55:37 UTC
Unfortunately no change on Ubuntu with 4.2.0-dev from 21.10.2016. 

But as it solves a crash on FreeBSD and involves only minimal code change I would like to ask for release blocker for 4.1.4.
Comment 6 Raphael Bircher 2016-12-17 22:22:50 UTC
@Matthias

So bring it to the list
Comment 7 Matthias Seidel 2016-12-17 22:25:19 UTC
(In reply to Raphael Bircher from comment #6)
> @Matthias
> 
> So bring it to the list

I already marked it as release_blocker.

Let the release manager decide...
Comment 8 SVN Robot 2017-02-02 23:15:10 UTC
"arielch" committed SVN revision 1781484 into branches/AOO414:
i127165 -  Catch the right excepction
Comment 9 Ariel Constenla-Haile 2017-02-02 23:16:00 UTC
Revision 1765170 is merged on branch AOO414.