|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | return type mismatch - return by value assigned to reference | ||
|---|---|---|---|
| Product: | Calc | Reporter: | khendricks |
| Component: | code | Assignee: | khendricks |
| Status: | CLOSED FIXED | QA Contact: | issues@sc <issues> |
| Severity: | Trivial | ||
| Priority: | P1 (highest) | CC: | issues |
| Version: | OOo 1.1 Beta2 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
| Issue Depends on: | |||
| Issue Blocks: | 13400 | ||
Hi Niklas, it seems this one is yours. Frank reassigned and reset prio It's Eike's code. accepted review done Fixed on branch cws_srx644_ooo11beta2: sc/inc/token.hxx 1.6.138.1 sc/source/core/data/cell2.cxx 1.17.140.3 sc/source/core/tool/compiler.cxx 1.40.24.3 sc/source/core/tool/rangenam.cxx 1.12.32.3 Kevin, please verify in cws_srx644_ooo11beta2 and close if present in SRX645_m5s1 or later. I guess resolved fixed is the correct status for this one. set to verified closed verified |
gcc 3.3 now provides error messages when there are return type mismatches such as when a method returns an object by value that is assigned to a reference which is a bug since the reference points to a temporary variable created to hold the return by value. An occurrence of this type occurred here see ... (fixme?) Please evaluate that line and fix the code in question to prevent the bug if needed. sc/source/core/tool/compiler.cxx @@ -2989,7 for( ScToken* t = pArr->GetNextReference(); t; t = pArr->GetNextReference() ) { (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/tool/compiler.cxx @@ -3029,7 // Absolute references have been already adjusted in the named // shared formula itself prior to breaking the shared formula // and calling this function. Don't readjust them again. (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/tool/rangenam.cxx @@ -390,7 { if( t->GetType() != svIndex ) { (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/tool/rangenam.cxx @@ -420,7 { if( t->GetType() != svIndex ) { (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/data/cell2.cxx @@ -1198,7 t->CalcAbsIfRel( aOldPos ); BOOL bMod; { // own scope for SingleDoubleRefModifier dtor if SingleRef (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/data/cell2.cxx @@ -1227,7 t->CalcAbsIfRel( aOldPos ); BOOL bMod; { // own scope for SingleDoubleRefModifier dtor if SingleRef (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/data/cell2.cxx @@ -1286,7 t->CalcAbsIfRel( aPos ); BOOL bMod; { // own scope for SingleDoubleRefModifier dtor if SingleRef (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref(); sc/source/core/data/cell2.cxx @@ -1315,7 +1315,7 @@ t->CalcAbsIfRel( aPos ); BOOL bMod; { // own scope for SingleDoubleRefModifier dtor if SingleRef (fixme?) SingleDoubleRefModifier& rMod = (t->GetType() == svSingleRef ? SingleDoubleRefModifier( t->GetSingleRef() ) : SingleDoubleRefModifier( t->GetDoubleRef() )); ComplRefData& rRef = rMod.Ref();