|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Excel displays Grid lines on a per sheet basis, Calc on a per document basis | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Calc | Reporter: | john.marmion | ||||||||
| Component: | formatting | Assignee: | AOO issues mailing list <issues> | ||||||||
| Status: | CONFIRMED --- | QA Contact: | |||||||||
| Severity: | Trivial | ||||||||||
| Priority: | P3 | CC: | burnuser, frank.loehmann, issues, kamataki, kami911, kpalagin, kyoshida, mr_smyle, niklas.nebel, pagalmes.lists | ||||||||
| Version: | recent-trunk | Keywords: | ms_interoperability, rfe_eval_ok, usability | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||||
| Developer Difficulty: | --- | ||||||||||
| Attachments: |
|
||||||||||
|
Description
john.marmion
2003-05-26 11:10:41 UTC
Created attachment 6426 [details]
sample doc
Hi Bettina, one4you Summary: Calc displays the grid lines on a per doc basis based on the settings from the first visible sheet instead of displaying the grid per sheet basis. Hello Niklas, please give approval for this evaluated OO.o 2.0 flagged issue. If you confirm with the target OO.o 2.0, then please keep it on your owner (or the owner of the concerning developer) for implementation. In case you want this issue for 'OOo Later', then please reset the target milestone. If you decline the issue finally, please set the resolution to 'Wontfix' (but do not close). In case of 'OOo Later' or 'Wontfix' please reset it on Bettina's owner. Thank you. This is not on the list of features that we're going to do for 2.0. We need to focus on the enhancements from the PCD document. enhanced summary, set keywords and reassigned issue according to RFE process I'm working on this feature, and my provisional code is already in ooo-build trunk. I'll upstream it once it's ready. Created attachment 51660 [details]
proposed patch
issue type PATCH. The patch takes care of: 1) storing the grid line setting with an appropriate table model instance, 2) Excel import/export 3) ODF import/export 4) put a new icon in the formatting object toolbar. The patch, however, does not include a new icon since we can't include binary files in a patch. cc Frank for usability. About the patch: I don't like the idea of moving some of the view settings down into the document (table). This could instead be similar to the recent "zoom per sheet" change. But moving this into the table model makes it easier to access during Excel import/export. Accessing view data from the Excel filter code is a little difficult. Since this data gets saved with the document, IMO it makes sense to store it in the document model. Actually the Excel filter does handle the table zoom factors just fine. Let me look into that then. Created attachment 52102 [details]
revised patch
@nn: I've attached a revised patch to move the location of where this show-grid option is stored. A quick second review would be appreciated. If you think the patch is in good condition, I will create a CWS to commit this patch. There are also a new icon set for this command but we did it only for the Tango theme. I will attach the icon files shortly. nn, pease review this voted patch and see if it can be finally integrated. Kohei, do you already have an icon for this issue? Thanks a lot. WBR, KP. AFAIK icons are here: http://svn.gnome.org/viewvc/ooo-build/trunk/src/icons/ *_togglesheetgrid.png *** Issue 114931 has been marked as a duplicate of this issue. *** I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob In OO 4.0 the Gridlines on/off has a checkbox in the new sidebar, but works still only for the whole document and not per sheet like in Excel or LibreOffice. Please change! |