Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | W32-tcsh doesn't build boost, icu | ||
---|---|---|---|
Product: | Build Tools | Reporter: | quetschke |
Component: | code | Assignee: | quetschke |
Status: | CLOSED FIXED | QA Contact: | issues@tools <issues> |
Severity: | Trivial | ||
Priority: | P1 (highest) | CC: | foskey, issues, quetschke |
Version: | OOo 1.1 Beta2 | ||
Target Milestone: | OOo 1.1 RC | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
quetschke
2003-06-23 17:41:03 UTC
retargeted. it was quite suprising to me too that this line is evaluated on windows at all. the hidden plan behind the "+" is that it forces execution in a shell rather than doing an exec on the binary itself. this was needed as "which" is an internal command in 4nt 4.xx which requires a shell to be found at all. since in case of an error the if statement isn't true anyway, i replaced "+which" with "+-" in at least "icu" and "python". the same workaround should dop in "boost". so please add the "-" rather than removing the "+". - Also noted on AIX. Error message is coming from dmake/function.c The issue is that cc is not a valid command in my system so therefore the command `which cc` returns a CC=1 and it fails the command. The base problem may be a buffer overflow there is 318 characters in my value returned. To fail on systems that works simply use a dummy as a command and see what happens. Work around for me is to code gcc in the short term. not all "cc" are a link to a "gcc". doing a "which gcc" would render this statement useless... Committed the '+' -> '+-' change to icu/makefile.mk and boost/makefile.mk. Works for me now. Ken, can you verify for AIX? Verified on AIX as well. NOTE: Do not confuse a work around by a patch by the way. The issue is in AIX there is NO cc command at all (unless you install xlc) Closed. Yes, but the bug is in dmake, the .IF "$(BUILD_TOOLS)$/cc"=="$(shell +which cc)" line should only be evaluated for "$(COMNAME)"=="sunpro5", neither AIX, nor W32-something has a cc. We could raise an issue for that or keep the workaround. |