Issue 28295

Summary:

gcc34 STLport patch

Product:

porting

Reporter:

fa <dan>

Component:

code

Assignee:

fa <dan>

Status:

CLOSED FIXED

QA Contact:

issues@porting <issues>

Severity:

Trivial

Priority:

CC:

issues, sander_traveling

Version:

OOo 1.1.1

Target Milestone:

OOo 2.0

Hardware:

All

OS:

All

Issue Type:

PATCH

Latest Confirmation in:

---

Developer Difficulty:

---

Issue Depends on:

Issue Blocks:

28294

Attachments:

Description	Flags
replace stlport/STLport-4.5.patch wtih this file	none
STLport-4.5.3 patch so far appears to work with gcc-3.4.0	none
suplemental patch to STLport-4.5.3 to patch /stlport/makefile.mk to use STLport-4.5.3	none
Additional STLport patch required to deal with "linux" keyword	none

Description fa 2004-04-23 15:47:49 UTC

STLport needs a slight change for gcc 3.4.

For example, STLport/stlport/stl/_alloc.h:416

  typedef typename _Allocator::_STLP_TEMPLATE rebind<_Tp> _Rebind_type;

gcc34 complains that one must use "_Allocator::template".

_STLP_TEMPLATE is defined in STLport/stlport/stl/_config.h:623

# ifndef _STLP_NO_MEMBER_TEMPLATE_KEYWORD
#   define _STLP_TEMPLATE template
# else
#   define _STLP_TEMPLATE
# endif

Currently, STLport's config/stl_gcc.h specifically #undef's
_STLP_NO_MEMBER_TEMPLATE_KEYWORD, resulting in the above error.  Patch corrects
that behavior, and adds a "return NULL" to another function in _ios_base.h to
suppress a gcc warning.

Comment 1 fa 2004-04-23 15:48:32 UTC

Created attachment 14729 [details]
replace stlport/STLport-4.5.patch wtih this file

Comment 2 Martin Hollmichel 2004-04-23 15:53:58 UTC

set target.

Comment 3 fa 2004-04-28 17:02:10 UTC

I'm not quite happy with these patches, I'd like to investigate options a bit
more here.  It seems somewhat stupid to have to keep doing "self->" for
everything GCC complains about, and I'm afraid it may have to be done for a lot
of code.  If there is a way that touches less code, we should do that.

Comment 4 sander_traveling 2004-04-28 17:36:05 UTC

did you check if / what happens if member templates are turned on for gcc34? if
it works with gcc34, and doesn't cause exported symbols to change somewhere we
could add a gcc34 specific exception to stl_gcc.

Comment 5 irf 2004-05-07 16:16:25 UTC

on my distro, gentoo, STLport-4.5.3 is used when building OOo
so i'm going to go ahead and submit the STLport-4.5.3 which
is been used with gcc-3.4.0
hth

Comment 6 irf 2004-05-07 16:20:02 UTC

Created attachment 15066 [details]
STLport-4.5.3 patch so far appears to work with gcc-3.4.0

Comment 7 irf 2004-05-07 16:23:03 UTC

Created attachment 15067 [details]
suplemental patch to STLport-4.5.3 to patch /stlport/makefile.mk to use STLport-4.5.3

Comment 8 Martin Hollmichel 2004-06-02 12:33:41 UTC

reassign to Dan

Comment 9 fa 2004-06-04 15:57:30 UTC

irf: your STLport 4.5.3 patch has large new chunks in it.  can you please
explain the changes?

STLport-4.5.patch committed to cws_src680_gcc34fixes01

Comment 10 fa 2004-07-08 18:54:06 UTC

Created attachment 16332 [details]
Additional STLport patch required to deal with "linux" keyword

Comment 11 fa 2004-07-13 21:30:19 UTC

July 8th patch committed to cws_src680_gcc340fixes01

Comment 12 jens-heiner.rechtien 2004-08-11 17:28:29 UTC

closing ...