Issue 28656

Summary: WW8: centered rtl table moves to the left on import from MSword
Product: Internationalization Reporter: sforbes <xslf>
Component: BiDiAssignee: michael.ruess
Status: CLOSED FIXED QA Contact: issues@l10n <issues>
Severity: Trivial    
Priority: P3 CC: alan, elisko, issues, kaplanlior, yba
Version: currentKeywords: ms_interoperability
Target Milestone: ---   
Hardware: PC   
OS: Windows Server 2003   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
problem doc
none
proposed patch
none
fixes the table properties "Alignment" and "Spacing" for RTL
none
Updated patch doesn't conflict w/ 97023 patch none

Description sforbes 2004-05-03 13:31:40 UTC
OOo 680m36: whem improting the attached word2003 doc, the table which was
originly centered moves to the left.
Comment 1 sforbes 2004-05-03 13:32:59 UTC
Created attachment 14932 [details]
problem doc
Comment 2 sforbes 2004-06-21 15:08:54 UTC
adding dina as cc
Comment 3 Dieter.Loeschky 2004-07-05 11:22:03 UTC
DL->MRU: Could you please handle this?
Comment 4 michael.ruess 2004-07-09 14:39:25 UTC
This is the same as internal task 116984. 
Comment 5 Unknown 2004-07-21 20:51:42 UTC
Please add keywords: ms_interoperability
Comment 6 martin_maher 2004-09-06 15:59:49 UTC
MM: Due to lack of resources I have to move this to "OO Later"
Comment 7 alan 2004-09-12 07:44:03 UTC
mmaher,I'd like to take this bug on, if it's not already fixed. Have you done 
any work on fixing the bug that I might benefit from?

mru mentioned that this is the same as internal task 116984. Is there a place 
where I can find the task description, and engineers' comments on the task?
Comment 8 martin_maher 2005-04-13 17:13:29 UTC
mmaher->flr: Yours I think
Comment 9 alan 2005-11-27 19:02:49 UTC
ayaniger->flr:
The attached patch fixes the problem. Could you take a look to make sure it
doesn't break anything else?
Comment 10 alan 2005-11-27 19:04:28 UTC
Created attachment 31838 [details]
proposed patch
Comment 11 Mathias_Bauer 2006-08-30 14:56:51 UTC
assigned to hbrinkm
Comment 12 alan 2007-05-17 14:09:59 UTC
ayaniger->hbrinkm:
Have you had a chance to review this patch?
Comment 13 kaplanlior 2008-05-08 20:41:07 UTC
@hbrinkm: Any news about this patch ?
Comment 14 alan 2008-11-18 16:36:51 UTC
The title of this issue is misleading, since the table is right aligned, not
centered. Careful examination shows that the table is physically not quite in
the middle.

The problem is that the table alignment is set to "Right", and aligned to the
right text margin. Instead, it should be set to "From Left", with the
"Spacing/Right" setting matching the "Indent from Right" setting in Word.

I'm posting an improved patch, which contains the required fix.
Comment 15 alan 2008-11-18 16:39:34 UTC
Created attachment 58087 [details]
fixes the table properties "Alignment" and "Spacing" for RTL
Comment 16 openoffice 2008-11-19 16:21:00 UTC
Sending        source/filter/ww8/ww8par2.cxx
Sending        source/filter/ww8/ww8par6.cxx
Transmitting file data ..
Committed revision 264008.
Comment 17 openoffice 2008-11-19 16:22:44 UTC
set target
Comment 18 openoffice 2008-12-01 13:38:40 UTC
ready for QA
Comment 19 michael.ruess 2008-12-08 14:17:13 UTC
Verified in CWS hb12.
Comment 20 michael.ruess 2009-01-09 17:06:42 UTC
Checked in DEV300m38.
Comment 21 elisko 2009-01-13 18:30:09 UTC
Created attachment 59362 [details]
Updated patch doesn't conflict w/ 97023 patch
Comment 22 elisko 2009-01-13 18:32:40 UTC
The patch I just submitted is the modified version we're using with the Hebrew 
3.0 release, to avoid conflict with other patches.
Comment 23 michael.ruess 2009-01-14 10:23:53 UTC
elisko,
please do not attach patch proposals to already integrated issues. File a new
issue if you like to have additional patches or fixes.
Thanks for your understanding!